Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285913002: SkPDF: Move SkFlate into src/pdf (part 1/3) [reland] (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Move SkFlate into src/pdf (part 1/3) [reland] Rename to SkDeflate so Chromium builders continue to work Next, we change remove SkFlate from Chromium build files, then we can delete SkFlate. Committed: https://skia.googlesource.com/skia/+/d9e57158ebd9b1f8317f0d76ef0402cfce0b0253

Patch Set 1 #

Patch Set 2 : 2015-08-12 (Wednesday) 13:09:57 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -310 lines) Patch
M gyp/pdf.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/pdf.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
D gyp/skflate.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M src/core/SkFlate.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
M src/core/SkFlate.cpp View 1 1 chunk +0 lines, -218 lines 0 comments Download
A + src/pdf/SkDeflate.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkDeflate.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFStream.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/PDFDeflateWStreamTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/PDFFlateTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
hal.canary
PTAL
5 years, 4 months ago (2015-08-11 21:35:26 UTC) #2
bungeman-skia
lgtm
5 years, 4 months ago (2015-08-11 21:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285913002/1
5 years, 4 months ago (2015-08-12 14:30:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e14c1fe04fc72ec9bcf55820b5c65a71d7d0a764
5 years, 4 months ago (2015-08-12 14:39:36 UTC) #6
hal.canary
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1289863002/ by halcanary@google.com. ...
5 years, 4 months ago (2015-08-12 15:52:55 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285913002/20001
5 years, 4 months ago (2015-08-12 17:11:28 UTC) #9
hal.canary
Trying again.
5 years, 4 months ago (2015-08-12 17:13:05 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 17:17:59 UTC) #12
bungeman-skia
lgtm
5 years, 4 months ago (2015-08-12 18:23:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285913002/20001
5 years, 4 months ago (2015-08-12 18:24:06 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:24:44 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d9e57158ebd9b1f8317f0d76ef0402cfce0b0253

Powered by Google App Engine
This is Rietveld 408576698