Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 128583002: Removal of GetDefaultProfile for new charger messages (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 11 months ago
Reviewers:
oshima, jennyz
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Removal of GetDefaultProfile for new charger messages As discussed - it's time to get rid of the GetDefaultProfile now. BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243963

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/chromeos/charger_replace/charger_link_dialog.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/charger_replace/charger_replacement_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc View 1 chunk +7 lines, -3 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 11 months ago (2014-01-08 16:34:17 UTC) #1
jennyz
https://codereview.chromium.org/128583002/diff/1/chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc File chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc (right): https://codereview.chromium.org/128583002/diff/1/chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc#newcode82 chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc:82: this); Will ProfileManager::GetActiveUserProfile() replacement work for the case of ...
6 years, 11 months ago (2014-01-08 18:43:02 UTC) #2
Mr4D (OOO till 08-26)
Please see comment! https://codereview.chromium.org/128583002/diff/1/chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc File chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc (right): https://codereview.chromium.org/128583002/diff/1/chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc#newcode82 chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc:82: this); Yes. It does the same ...
6 years, 11 months ago (2014-01-08 18:58:28 UTC) #3
jennyz
lgtm
6 years, 11 months ago (2014-01-08 19:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/128583002/1
6 years, 11 months ago (2014-01-08 20:18:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43881
6 years, 11 months ago (2014-01-08 20:44:57 UTC) #6
Mr4D (OOO till 08-26)
Oshima can you please do the owners review?
6 years, 11 months ago (2014-01-08 20:55:52 UTC) #7
oshima
lgtm
6 years, 11 months ago (2014-01-09 16:40:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/128583002/1
6 years, 11 months ago (2014-01-09 16:55:59 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 20:22:04 UTC) #10
Message was sent while issue was closed.
Change committed as 243963

Powered by Google App Engine
This is Rietveld 408576698