Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: Source/core/page/CustomContextMenuProvider.cpp

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change bool on SimulatedMouseEvent to the enum class introduced everywhere else Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLElement.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/page/CustomContextMenuProvider.h" 6 #include "core/page/CustomContextMenuProvider.h"
7 7
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/dom/ElementTraversal.h" 9 #include "core/dom/ElementTraversal.h"
10 #include "core/events/EventDispatcher.h" 10 #include "core/events/EventDispatcher.h"
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 39
40 void CustomContextMenuProvider::populateContextMenu(ContextMenu* menu) 40 void CustomContextMenuProvider::populateContextMenu(ContextMenu* menu)
41 { 41 {
42 populateContextMenuItems(*m_menu, *menu); 42 populateContextMenuItems(*m_menu, *menu);
43 } 43 }
44 44
45 void CustomContextMenuProvider::contextMenuItemSelected(const ContextMenuItem* i tem) 45 void CustomContextMenuProvider::contextMenuItemSelected(const ContextMenuItem* i tem)
46 { 46 {
47 if (HTMLElement* element = menuItemAt(item->action())) { 47 if (HTMLElement* element = menuItemAt(item->action())) {
48 RefPtrWillBeRawPtr<SimulatedMouseEvent> click = SimulatedMouseEvent::cre ate(EventTypeNames::click, m_menu->document().domWindow(), Event::create()); 48 RefPtrWillBeRawPtr<SimulatedMouseEvent> click = SimulatedMouseEvent::cre ate(EventTypeNames::click, m_menu->document().domWindow(), Event::create(), Simu latedClickCreationScope::FromUserAgent);
49 click->setRelatedTarget(m_subjectElement.get()); 49 click->setRelatedTarget(m_subjectElement.get());
50 element->dispatchEvent(click.release()); 50 element->dispatchEvent(click.release());
51 } 51 }
52 } 52 }
53 53
54 void CustomContextMenuProvider::contextMenuCleared() 54 void CustomContextMenuProvider::contextMenuCleared()
55 { 55 {
56 m_menuItems.clear(); 56 m_menuItems.clear();
57 m_subjectElement = nullptr; 57 m_subjectElement = nullptr;
58 } 58 }
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 132
133 HTMLElement* CustomContextMenuProvider::menuItemAt(unsigned menuId) 133 HTMLElement* CustomContextMenuProvider::menuItemAt(unsigned menuId)
134 { 134 {
135 int itemIndex = menuId - ContextMenuItemBaseCustomTag; 135 int itemIndex = menuId - ContextMenuItemBaseCustomTag;
136 if (itemIndex < 0 || static_cast<unsigned long>(itemIndex) >= m_menuItems.si ze()) 136 if (itemIndex < 0 || static_cast<unsigned long>(itemIndex) >= m_menuItems.si ze())
137 return nullptr; 137 return nullptr;
138 return m_menuItems[itemIndex].get(); 138 return m_menuItems[itemIndex].get();
139 } 139 }
140 140
141 } // namespace blink 141 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLElement.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698