Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1285793002: Debugger: correctly find closure to recompile eval for debugging. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: correctly find closure to recompile eval for debugging. R=mstarzinger@chromium.org BUG=chromium:517592 LOG=N Committed: https://crrev.com/a68ad56c508d98678315f00a7da0f7580524a131 Cr-Commit-Position: refs/heads/master@{#30104}

Patch Set 1 #

Patch Set 2 : mark toplevel eval as not allow recompile without context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M src/compiler.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-517592.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years, 4 months ago (2015-08-11 07:12:55 UTC) #1
Michael Starzinger
LGTM.
5 years, 4 months ago (2015-08-11 07:50:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285793002/20001
5 years, 4 months ago (2015-08-11 07:55:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 08:20:35 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 08:20:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a68ad56c508d98678315f00a7da0f7580524a131
Cr-Commit-Position: refs/heads/master@{#30104}

Powered by Google App Engine
This is Rietveld 408576698