Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1285733002: Pass buffer offset to PlayOutputBuffer() call (Closed)

Created:
5 years, 4 months ago by qinmin
Modified:
5 years, 4 months ago
Reviewers:
Tima Vaisburd
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass buffer offset to PlayOutputBuffer() call DequeueOutputBuffer returns a buffer index along with size and offset information. The offset is however ignored in PlayOutputBuffer() call. This change fixes this issue by passing the offset to PlayOutputBuffer(). BUG=519058 Committed: https://crrev.com/5ffd27c488642c43479a2d9d1450ce3057c20c3c Cr-Commit-Position: refs/heads/master@{#344924}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add a separate function to get output buffer address #

Patch Set 3 : fix bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -20 lines) Patch
M media/base/android/audio_decoder_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/audio_decoder_job.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/android/media_codec_audio_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_codec_audio_decoder.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/base/android/media_codec_bridge.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 2 3 chunks +24 lines, -14 lines 0 comments Download
M media/base/android/media_codec_decoder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_codec_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_codec_video_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_codec_video_decoder.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_decoder_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/video_decoder_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/video_decoder_job.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
qinmin
PTAL
5 years, 4 months ago (2015-08-10 23:27:57 UTC) #2
Tima Vaisburd
lgtm % nit https://codereview.chromium.org/1285733002/diff/1/media/base/android/media_codec_bridge.cc File media/base/android/media_codec_bridge.cc (right): https://codereview.chromium.org/1285733002/diff/1/media/base/android/media_codec_bridge.cc#newcode708 media/base/android/media_codec_bridge.cc:708: uint8* buffer = nit: This code ...
5 years, 4 months ago (2015-08-11 19:25:40 UTC) #3
qinmin
https://codereview.chromium.org/1285733002/diff/1/media/base/android/media_codec_bridge.cc File media/base/android/media_codec_bridge.cc (right): https://codereview.chromium.org/1285733002/diff/1/media/base/android/media_codec_bridge.cc#newcode708 media/base/android/media_codec_bridge.cc:708: uint8* buffer = On 2015/08/11 19:25:40, Tima Vaisburd wrote: ...
5 years, 4 months ago (2015-08-20 18:34:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285733002/20001
5 years, 4 months ago (2015-08-20 18:36:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58444)
5 years, 4 months ago (2015-08-21 00:41:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285733002/40001
5 years, 4 months ago (2015-08-21 16:59:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59081)
5 years, 4 months ago (2015-08-21 20:16:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285733002/40001
5 years, 4 months ago (2015-08-21 20:47:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285733002/60001
5 years, 4 months ago (2015-08-21 23:05:25 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/51107)
5 years, 4 months ago (2015-08-21 23:39:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285733002/60001
5 years, 4 months ago (2015-08-21 23:45:23 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 4 months ago (2015-08-22 00:04:24 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:04:53 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ffd27c488642c43479a2d9d1450ce3057c20c3c
Cr-Commit-Position: refs/heads/master@{#344924}

Powered by Google App Engine
This is Rietveld 408576698