Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 128573002: Small tweaks to be able to build everything target: (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Small tweaks to be able to build everything target: - fParsed is unused. - Quiet down a bogus -Wuninitialized warning in QWeakPointer. Tested Clang and GCC on Linux. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12970

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M experimental/PdfViewer/SkPdfFont.h View 1 chunk +0 lines, -1 line 1 comment Download
M experimental/PdfViewer/SkPdfFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/debugger.gyp View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 11 months ago (2014-01-08 16:28:53 UTC) #1
bungeman-skia
lgtm https://codereview.chromium.org/128573002/diff/1/experimental/PdfViewer/SkPdfFont.h File experimental/PdfViewer/SkPdfFont.h (left): https://codereview.chromium.org/128573002/diff/1/experimental/PdfViewer/SkPdfFont.h#oldcode88 experimental/PdfViewer/SkPdfFont.h:88: SkPdfNativeDoc* fParsed; Must admit I have no idea ...
6 years, 11 months ago (2014-01-08 16:41:35 UTC) #2
mtklein
https://codereview.chromium.org/128573002/diff/1/gyp/debugger.gyp File gyp/debugger.gyp (right): https://codereview.chromium.org/128573002/diff/1/gyp/debugger.gyp#newcode147 gyp/debugger.gyp:147: # Clang gets confused by QWeakPointer, see http://llvm.org/bugs/show_bug.cgi?id=13127 On ...
6 years, 11 months ago (2014-01-08 16:53:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/128573002/1
6 years, 11 months ago (2014-01-08 16:53:35 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:16:17 UTC) #5
Message was sent while issue was closed.
Change committed as 12970

Powered by Google App Engine
This is Rietveld 408576698