Source/platform/fonts/UTF16TextIterator.h - Issue 1285633003: Change handling of unmatched surrogate pairs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/UTF16TextIterator.h

Issue 1285633003: Change handling of unmatched surrogate pairs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressing reviewer comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/UTF16TextIterator.h

diff --git a/Source/platform/fonts/UTF16TextIterator.h b/Source/platform/fonts/UTF16TextIterator.h

index 6a2ec343fdd5c9f29cc3b531f24b35724766bbf6..f42c7ad123f0e643e834c20cc25ca685dca70154 100644

--- a/Source/platform/fonts/UTF16TextIterator.h

+++ b/Source/platform/fonts/UTF16TextIterator.h

@@ -68,6 +68,7 @@ public:

unsigned glyphLength() const { return m_currentGlyphLength; }

private:

+ bool isValidSurrogatePair(UChar32&);

bool consumeSurrogatePair(UChar32&);

void consumeMultipleUChar();