Change handling of unmatched surrogate pairs

Change handling of unmatched surrogate pairs

Change the way blink handles unmatched or invalid UTF16 surrogate pairs.
Formerly once an unmatched on invalid surrogate pair was encountered the
processing of the text node was aborted, resulting in the text following
the invalid surrogate pair to be trimmed.

With this change the unmatched/invalid pair is instead replaced with the
unicode replacement character and the rest of the node handled normally.

This matches the behavior of Firefox and Internet Explorer.

R=bsittler@chromium.org
BUG=518039
TEST=fast/text/unmatched-surrogate-pair.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200348

[eae, 2015-08-10 18:45:23]

eae@chromium.org changed reviewers:
+ bsittler@chromium.org

[eae, 2015-08-10 19:59:02]

eae@chromium.org changed reviewers:
+ senorblanco@chromium.org

[eae, 2015-08-11 18:08:05]

Patchset #2 (id:20001) has been deleted

[eae, 2015-08-11 18:08:19]

Made the suggested test changes.

[bsittler, 2015-08-11 18:11:01]

lgtm

https://codereview.chromium.org/1285633003/diff/1/LayoutTests/fast/text/unmat...
File LayoutTests/fast/text/unmatched-surrogate-pair.html (right):

https://codereview.chromium.org/1285633003/diff/1/LayoutTests/fast/text/unmat...
LayoutTests/fast/text/unmatched-surrogate-pair.html:20: appendLine('Full
codepoint, "\u{1F30E}". Prints a globle glyph.');
tiny typo: s/globle/globe

[eae, 2015-08-11 18:12:35]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285633003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285633003/40001

[commit-bot: I haz the power, 2015-08-11 18:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:13:19]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bsittler, 2015-08-11 18:16:05]

On 2015/08/11 at 18:11:01, bsittler wrote:
> lgtm
> 
>
https://codereview.chromium.org/1285633003/diff/1/LayoutTests/fast/text/unmat...
> File LayoutTests/fast/text/unmatched-surrogate-pair.html (right):
> 
>
https://codereview.chromium.org/1285633003/diff/1/LayoutTests/fast/text/unmat...
> LayoutTests/fast/text/unmatched-surrogate-pair.html:20: appendLine('Full
codepoint, "\u{1F30E}". Prints a globle glyph.');
> tiny typo: s/globle/globe

Ignore that comment, please. You already fixed it :)

[leviw_travelin_and_unemployed, 2015-08-11 18:17:17]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-08-11 18:17:17]

rs lgtm

[leviw_travelin_and_unemployed, 2015-08-11 18:17:21]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285633003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285633003/40001

[commit-bot: I haz the power, 2015-08-11 19:43:31]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200348