content/browser/browser_plugin/browser_plugin_guest_manager.h - Issue 128563002: BrowserPlugin: Implemented BrowserPluginGuestManager::ForEachGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest_manager.h

Issue 128563002: BrowserPlugin: Implemented BrowserPluginGuestManager::ForEachGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed spacing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest_manager.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest_manager.h b/content/browser/browser_plugin/browser_plugin_guest_manager.h

index f0bee02966465c212e6cb4e3a36829818b4be5d2..b1b6b095886c888305876593942bc3e7729ce3ae 100644

--- a/content/browser/browser_plugin/browser_plugin_guest_manager.h

+++ b/content/browser/browser_plugin/browser_plugin_guest_manager.h

@@ -37,7 +37,6 @@ class RenderWidgetHostImpl;

class SiteInstance;

class WebContents;

class WebContentsImpl;

-struct NativeWebKeyboardEvent;

// WARNING: All APIs should be guarded with a process ID check like

// CanEmbedderAccessInstanceIDMaybeKill, to prevent abuse by normal renderer

@@ -87,10 +86,9 @@ class CONTENT_EXPORT BrowserPluginGuestManager :

bool CanEmbedderAccessInstanceIDMaybeKill(int embedder_render_process_id,

int instance_id) const;

- void DidSendScreenRects(WebContentsImpl* embedder_web_contents);

- bool UnlockMouseIfNecessary(WebContentsImpl* embedder_web_contents_,

- const NativeWebKeyboardEvent& event);

+ typedef base::Callback<bool(BrowserPluginGuest*)> GuestCallback;

+ bool ForEachGuest(WebContentsImpl* embedder_web_contents,

+ const GuestCallback& callback);

void OnMessageReceived(const IPC::Message& message, int render_process_id);