BrowserPlugin: Implemented BrowserPluginGuestManager::ForEachGuest

content/browser/browser_plugin/browser_plugin_guest_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A BrowserPluginGuestManager serves as a message router to BrowserPluginGuests
 // for all guests within a given profile.
 // Messages are routed to a particular guest instance based on an instance_id.
 
 #ifndef CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_MANAGER_H_
 #define CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_MANAGER_H_
@@ skipping 19 matching lines @@
 
 namespace content {
 
 class BrowserPluginGuest;
 class BrowserPluginHostFactory;
 class RenderProcessHostImpl;
 class RenderWidgetHostImpl;
 class SiteInstance;
 class WebContents;
 class WebContentsImpl;
-struct NativeWebKeyboardEvent;
 
 // WARNING: All APIs should be guarded with a process ID check like
 // CanEmbedderAccessInstanceIDMaybeKill, to prevent abuse by normal renderer
 // processes.
 class CONTENT_EXPORT BrowserPluginGuestManager :
     public base::SupportsUserData::Data {
  public:
   virtual ~BrowserPluginGuestManager();
 
   static BrowserPluginGuestManager* Create();
@@ skipping 29 matching lines @@
 
   // Removes the guest with the given |instance_id| from this
   // BrowserPluginGuestManager.
   void RemoveGuest(int instance_id);
 
   // Returns whether the specified embedder is permitted to access the given
   // |instance_id|, and kills the embedder if not.
   bool CanEmbedderAccessInstanceIDMaybeKill(int embedder_render_process_id,
                                             int instance_id) const;
 
-  void DidSendScreenRects(WebContentsImpl* embedder_web_contents);
-
-  bool UnlockMouseIfNecessary(WebContentsImpl* embedder_web_contents_,
-                              const NativeWebKeyboardEvent& event);
+  typedef base::Callback<bool(BrowserPluginGuest*)> GuestCallback;
+  bool ForEachGuest(WebContentsImpl* embedder_web_contents,
+                    GuestCallback callback);

[nasko, 2014/01/08 17:58:42]

Why not pass the callback as a const reference? An example is
FrameTree::ForEach.

[Fady Samuel, 2014/01/08 18:22:40]

Done.

 
   void OnMessageReceived(const IPC::Message& message, int render_process_id);
 
  private:
   friend class TestBrowserPluginGuestManager;
 
   BrowserPluginGuestManager();
 
   // Returns whether the given embedder process is allowed to access the
   // provided |guest|.
@@ skipping 26 matching lines @@
   GuestInstanceMap guest_web_contents_by_instance_id_;
   int next_instance_id_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuestManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_MANAGER_H_