net/data/parse_certificate_unittest/tbs_v1.pem - Issue 1285593003: Add parsing code for TBSCertificate's "validity" field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/parse_certificate_unittest/tbs_v1.pem

Issue 1285593003: Add parsing code for TBSCertificate's "validity" field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_parsing

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem ('k') | net/data/parse_certificate_unittest/tbs_v1_extensions.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/parse_certificate_unittest/tbs_v1.pem

diff --git a/net/data/parse_certificate_unittest/tbs_v1.pem b/net/data/parse_certificate_unittest/tbs_v1.pem

index bfd2f8c01fe939d651ce24880e9448ee2362bfa6..ae0ebbd7be75bb8ad01d0f0d4d1dd1c02ebe57d0 100644

--- a/net/data/parse_certificate_unittest/tbs_v1.pem

+++ b/net/data/parse_certificate_unittest/tbs_v1.pem

@@ -3,23 +3,24 @@ This is a TBSCertificate which omits the version field (meaning it is v1).

-----BEGIN TBS CERTIFICATE-----

-MBwCAQEwAwQBATADBAEFMAMEAQgwAwQBCjADBAHz

+MDcCAQEwAwQBATADBAEFMB4XDTEyMTAxODAzMTIwMFoXDTEzMTAxODE0NTk1OVowAwQBgzADBAH

-----END TBS CERTIFICATE-----

$ openssl asn1parse -i < [TBS CERTIFICATE]

- 0:d=0 hl=2 l= 28 cons: SEQUENCE

+ 0:d=0 hl=2 l= 55 cons: SEQUENCE

2:d=1 hl=2 l= 1 prim: INTEGER :01

5:d=1 hl=2 l= 3 cons: SEQUENCE

7:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

10:d=1 hl=2 l= 3 cons: SEQUENCE

12:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

- 15:d=1 hl=2 l= 3 cons: SEQUENCE

- 17:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:08

- 20:d=1 hl=2 l= 3 cons: SEQUENCE

- 22:d=2 hl=2 l= 1 prim: OCTET STRING :

- 25:d=1 hl=2 l= 3 cons: SEQUENCE

- 27:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

+ 15:d=1 hl=2 l= 30 cons: SEQUENCE

+ 17:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

+ 32:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

+ 47:d=1 hl=2 l= 3 cons: SEQUENCE

+ 49:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

+ 52:d=1 hl=2 l= 3 cons: SEQUENCE

+ 54:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

@@ -49,23 +50,31 @@ $ openssl asn1parse -i < [ISSUER]

------BEGIN VALIDITY-----

-MAMEAQg=

------END VALIDITY-----

+-----BEGIN VALIDITY NOTBEFORE-----

+eWVhcj0yMDEyLCBtb250aD0xMCwgZGF5PTE4LCBob3Vycz0zLCBtaW51dGVzPTEyLCBzZWNvbmR

+zPTA=

+-----END VALIDITY NOTBEFORE-----

-$ openssl asn1parse -i < [VALIDITY]

- 0:d=0 hl=2 l= 3 cons: SEQUENCE

- 2:d=1 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:08

+VALIDITY NOTBEFORE: year=2012, month=10, day=18, hours=3, minutes=12, seconds=0

+-----BEGIN VALIDITY NOTAFTER-----

+eWVhcj0yMDEzLCBtb250aD0xMCwgZGF5PTE4LCBob3Vycz0xNCwgbWludXRlcz01OSwgc2Vjb25

+kcz01OQ==

+-----END VALIDITY NOTAFTER-----

+VALIDITY NOTAFTER: year=2013, month=10, day=18, hours=14, minutes=59, seconds=59

-----BEGIN SUBJECT-----

-MAMEAQo=

+MAMEAYM=

-----END SUBJECT-----

$ openssl asn1parse -i < [SUBJECT]

0:d=0 hl=2 l= 3 cons: SEQUENCE

- 2:d=1 hl=2 l= 1 prim: OCTET STRING :

+ 2:d=1 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83