net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem - Issue 1285593003: Add parsing code for TBSCertificate's "validity" field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem

Issue 1285593003: Add parsing code for TBSCertificate's "validity" field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_parsing

Patch Set: rebase and fix a comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/data/parse_certificate_unittest/tbs_v3_extensions.pem ('K') | « net/data/parse_certificate_unittest/tbs_v3_extensions.pem ('k') | net/data/parse_certificate_unittest/tbs_v3_no_optionals.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem

diff --git a/net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem b/net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem

index 63df3caebb688ef1b0be2463088211ee6d075b73..ef2ca979b55ad6a64052a16170cdccdab468e395 100644

--- a/net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem

+++ b/net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem

@@ -4,11 +4,12 @@ STRING rather than a SEQUENCE.

-----BEGIN TBS CERTIFICATE-----

-MCigAwIBAgIBATADBAEBMAMEAQUwAwQBCDADBAEKMAMEAfOjBQQDBAHd

+MEOgAwIBAgIBATADBAEBMAMEAQUwHhcNMTIxMDE4MDMxMjAwWhcNMTMxMDE4MTQ1OTU5WjADBAG

+DMAMEAfOjBQQDBAHd

-----END TBS CERTIFICATE-----

$ openssl asn1parse -i < [TBS CERTIFICATE]

- 0:d=0 hl=2 l= 40 cons: SEQUENCE

+ 0:d=0 hl=2 l= 67 cons: SEQUENCE

2:d=1 hl=2 l= 3 cons: cont [ 0 ]

4:d=2 hl=2 l= 1 prim: INTEGER :02

7:d=1 hl=2 l= 1 prim: INTEGER :01

@@ -16,12 +17,12 @@ $ openssl asn1parse -i < [TBS CERTIFICATE]

12:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

15:d=1 hl=2 l= 3 cons: SEQUENCE

17:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

- 20:d=1 hl=2 l= 3 cons: SEQUENCE

- 22:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:08

- 25:d=1 hl=2 l= 3 cons: SEQUENCE

- 27:d=2 hl=2 l= 1 prim: OCTET STRING :

- 30:d=1 hl=2 l= 3 cons: SEQUENCE

- 32:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

- 35:d=1 hl=2 l= 5 cons: cont [ 3 ]

- 37:d=2 hl=2 l= 3 prim: OCTET STRING [HEX DUMP]:0401DD

+ 20:d=1 hl=2 l= 30 cons: SEQUENCE

+ 22:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

+ 37:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

+ 52:d=1 hl=2 l= 3 cons: SEQUENCE

+ 54:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

+ 57:d=1 hl=2 l= 3 cons: SEQUENCE

+ 59:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

+ 62:d=1 hl=2 l= 5 cons: cont [ 3 ]

+ 64:d=2 hl=2 l= 3 prim: OCTET STRING [HEX DUMP]:0401DD