net/data/parse_certificate_unittest/tbs_explicit_v1.pem - Issue 1285593003: Add parsing code for TBSCertificate's "validity" field.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/tbs_explicit_v1.pem

Issue 1285593003: Add parsing code for TBSCertificate's "validity" field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_parsing

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 This is an otherwise valid v1 certificate, except the version has been encoded	1 This is an otherwise valid v1 certificate, except the version has been encoded

2 explicitly as 0. Instead it should have been omitted.	2 explicitly as 0. Instead it should have been omitted.

3	3

4	4

5	5

6 -----BEGIN TBS CERTIFICATE-----	6 -----BEGIN TBS CERTIFICATE-----

7 MCGgAwIBAAIBATADBAEBMAMEAQUwAwQBCDADBAEKMAMEAfM=	7 MDygAwIBAAIBATADBAEBMAMEAQUwHhcNMTIxMDE4MDMxMjAwWhcNMTMxMDE4MTQ1OTU5WjADBAG

	8 DMAMEAfM=

8 -----END TBS CERTIFICATE-----	9 -----END TBS CERTIFICATE-----

9	10

10 $ openssl asn1parse -i < [TBS CERTIFICATE]	11 $ openssl asn1parse -i < [TBS CERTIFICATE]

11 0:d=0 hl=2 l= 33 cons: SEQUENCE	12 0:d=0 hl=2 l= 60 cons: SEQUENCE

12 2:d=1 hl=2 l= 3 cons: cont [ 0 ]	13 2:d=1 hl=2 l= 3 cons: cont [ 0 ]

13 4:d=2 hl=2 l= 1 prim: INTEGER :00	14 4:d=2 hl=2 l= 1 prim: INTEGER :00

14 7:d=1 hl=2 l= 1 prim: INTEGER :01	15 7:d=1 hl=2 l= 1 prim: INTEGER :01

15 10:d=1 hl=2 l= 3 cons: SEQUENCE	16 10:d=1 hl=2 l= 3 cons: SEQUENCE

16 12:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01	17 12:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

17 15:d=1 hl=2 l= 3 cons: SEQUENCE	18 15:d=1 hl=2 l= 3 cons: SEQUENCE

18 17:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05	19 17:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

19 20:d=1 hl=2 l= 3 cons: SEQUENCE	20 20:d=1 hl=2 l= 30 cons: SEQUENCE

20 22:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:08	21 22:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

21 25:d=1 hl=2 l= 3 cons: SEQUENCE	22 37:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

22 27:d=2 hl=2 l= 1 prim: OCTET STRING :	23 52:d=1 hl=2 l= 3 cons: SEQUENCE

23	24 54:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

24 30:d=1 hl=2 l= 3 cons: SEQUENCE	25 57:d=1 hl=2 l= 3 cons: SEQUENCE

25 32:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3	26 59:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

OLD	NEW