net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem - Issue 1285593003: Add parsing code for TBSCertificate's "validity" field.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem

Issue 1285593003: Add parsing code for TBSCertificate's "validity" field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_parsing

Patch Set: rebase and fix a comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem ('k') | net/data/parse_certificate_unittest/tbs_v1.pem » ('j') | net/data/parse_certificate_unittest/tbs_v3_extensions.pem » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This is a TBSCertificate which has a serial number that is 26 octets long. This	1 This is a TBSCertificate which has a serial number that is 26 octets long. This

2 violates RFC 5280.	2 violates RFC 5280.

3	3

4	4

5	5

6 -----BEGIN TBS CERTIFICATE-----	6 -----BEGIN TBS CERTIFICATE-----

7 MDqgAwIBAAIaQsg8eFVS5Dkn5IvhKA+iD5+wj0f5RMMmaPkwAwQBATADBAEFMAMEAQgwAwQBCjA	7 MFWgAwIBAAIaQsg8eFVS5Dkn5IvhKA+iD5+wj0f5RMMmaPkwAwQBATADBAEFMB4XDTEyMTAxODA

8 DBAHz	8 zMTIwMFoXDTEzMTAxODE0NTk1OVowAwQBgzADBAHz

9 -----END TBS CERTIFICATE-----	9 -----END TBS CERTIFICATE-----

10	10

11 $ openssl asn1parse -i < [TBS CERTIFICATE]	11 $ openssl asn1parse -i < [TBS CERTIFICATE]

12 0:d=0 hl=2 l= 58 cons: SEQUENCE	12 0:d=0 hl=2 l= 85 cons: SEQUENCE

13 2:d=1 hl=2 l= 3 cons: cont [ 0 ]	13 2:d=1 hl=2 l= 3 cons: cont [ 0 ]

14 4:d=2 hl=2 l= 1 prim: INTEGER :00	14 4:d=2 hl=2 l= 1 prim: INTEGER :00

15 7:d=1 hl=2 l= 26 prim: INTEGER :42C83C785552E43927E48BE1280FA20 F9FB08F47F944C32668F9	15 7:d=1 hl=2 l= 26 prim: INTEGER :42C83C785552E43927E48BE1280FA20 F9FB08F47F944C32668F9

16 35:d=1 hl=2 l= 3 cons: SEQUENCE	16 35:d=1 hl=2 l= 3 cons: SEQUENCE

17 37:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01	17 37:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

18 40:d=1 hl=2 l= 3 cons: SEQUENCE	18 40:d=1 hl=2 l= 3 cons: SEQUENCE

19 42:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05	19 42:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

20 45:d=1 hl=2 l= 3 cons: SEQUENCE	20 45:d=1 hl=2 l= 30 cons: SEQUENCE

21 47:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:08	21 47:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

22 50:d=1 hl=2 l= 3 cons: SEQUENCE	22 62:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

23 52:d=2 hl=2 l= 1 prim: OCTET STRING :	23 77:d=1 hl=2 l= 3 cons: SEQUENCE

24	24 79:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

25 55:d=1 hl=2 l= 3 cons: SEQUENCE	25 82:d=1 hl=2 l= 3 cons: SEQUENCE

26 57:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3	26 84:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

OLD	NEW