suggest "in" in for statement

pkg/analysis_server/test/services/completion/keyword_contributor_test.dart

Index: pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart b/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
index 22747cdcb24b97fbd246d8cce33603a687418f87..624aff293b72ad85736c52642962f87f81db59e8 100644
--- a/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
@@ -517,6 +517,18 @@ class KeywordContributorTest extends AbstractCompletionTest {
         relevance: DART_RELEVANCE_HIGH);
   }
 
+  test_for_expression_in() {

[Brian Wilkerson, 2015/08/10 13:56:18]

It would be good to have some negative tests here as well to ensure that we
don't suggest 'in' in a normal for loop, such as

for (int j = i^; j < length; j++) {}

[danrubel, 2015/08/10 14:42:25]

Good point. Added additional tests and handled new situation. Happy to address
any issues you find with the new code in a subsequent CL.

+    addTestSource('main() {for (int x i^)}');
+    expect(computeFast(), isTrue);
+    assertSuggestKeywords([Keyword.IN], relevance: DART_RELEVANCE_HIGH);
+  }
+
+  test_for_expression_in2() {

[Brian Wilkerson, 2015/08/10 13:56:18]

I'm not sure what the utility is of suggesting 'in' after the user types 'in'...

[danrubel, 2015/08/10 14:42:25]

It's good to ensure "in" is in the list of suggestions so that we don't
auto-insert something else when the user wanted "in".

+    addTestSource('main() {for (int x in^)}');
+    expect(computeFast(), isTrue);
+    assertSuggestKeywords([Keyword.IN], relevance: DART_RELEVANCE_HIGH);
+  }
+
   test_function_async() {
     addTestSource('main()^');
     expect(computeFast(), isTrue);