Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1285533002: [WEBPImageEncoder] Use local buffer allocation instead of WTF::Vector (Closed)

Created:
5 years, 4 months ago by Noel Gordon
Modified:
5 years, 4 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, jzern, skal, urvang, vikasa
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WEBPImageEncoder] Use local buffer allocation instead of WTF::Vector Blink r199183 changed the encoder to no longer reserve WTF::Vector capacity. An alternative is to no longer use a WTF::Vector, and allocate the buffer in an OwnPtr<T[]> instead. BUG=504690 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/platform/image-encoders/skia/WEBPImageEncoder.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Noel Gordon
Refer to https://code.google.com/p/chromium/issues/detail?id=459763#c17
5 years, 4 months ago (2015-08-10 06:03:58 UTC) #2
Noel Gordon
5 years, 4 months ago (2015-08-10 06:04:03 UTC) #3
Noel Gordon
Ping?
5 years, 4 months ago (2015-08-17 03:23:06 UTC) #4
Justin Novosad
On 2015/08/17 03:23:06, noel gordon wrote: > Ping? lgtm
5 years, 4 months ago (2015-08-17 14:46:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285533002/1
5 years, 4 months ago (2015-08-18 02:34:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99560)
5 years, 4 months ago (2015-08-18 03:57:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285533002/1
5 years, 4 months ago (2015-08-18 04:44:50 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:43:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200702

Powered by Google App Engine
This is Rietveld 408576698