Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 128553002: Add a new method to the ProfileInfoCacheObserver for signin status changes. (Closed)

Created:
6 years, 11 months ago by noms (inactive)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Nikita (slow)
Visibility:
Public.

Description

Add a new method to the ProfileInfoCacheObserver for signin status changes. BUG=332155 TBR=nkostylev@chromium.org TEST=With the --new-profile-management flag set, start Chrome. Sign in a profile, and choose "View all people" from the avatar bubble. With the user manager window open, lock the profile. The user manager should update the profile's pod with a lock icon. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
noms (inactive)
Hi Elliot, I added a new notification type to the ProfileInfoCache so that the user ...
6 years, 11 months ago (2014-01-08 16:48:53 UTC) #1
Elliot Glaysher
This is entirely cosmetic, but please don't say "notification type", since I first assumed you ...
6 years, 11 months ago (2014-01-08 18:57:21 UTC) #2
noms (inactive)
Done. Sorry! On 2014/01/08 18:57:21, Elliot Glaysher wrote: > This is entirely cosmetic, but please ...
6 years, 11 months ago (2014-01-08 19:00:45 UTC) #3
Elliot Glaysher
lgtm
6 years, 11 months ago (2014-01-08 19:03:47 UTC) #4
noms (inactive)
Thanks! TBR'ing Nikita for owners stamp on chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (it's a minor api change)
6 years, 11 months ago (2014-01-08 19:09:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/128553002/1
6 years, 11 months ago (2014-01-08 19:10:08 UTC) #6
commit-bot: I haz the power
Change committed as 243658
6 years, 11 months ago (2014-01-08 21:51:21 UTC) #7
Nikita (slow)
6 years, 11 months ago (2014-01-09 12:43:01 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698