Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1285463002: Revert of Re-enable ChannelMojo. (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@is-this-real-life
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable ChannelMojo. (patchset #1 id:40001 of https://codereview.chromium.org/1273283002/ ) Reason for revert: Still seeing flake on ChromeOS, and it's probably this again. Original issue's description: > Re-enable ChannelMojo. > > AGAIN! Previously reverted attempts: > > https://codereview.chromium.org/1262503011/ > https://codereview.chromium.org/1256473002/ > > SyncMessageFilter is set up to properly use thread-safe > Send channels now, so this should stick. > > Maybe. > > BUG=500019 > TBR=jam@chromium.org > > Committed: https://crrev.com/d34d184bd1a88043667b10cba79a5770bd2803fb > Cr-Commit-Position: refs/heads/master@{#342484} TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500019 Committed: https://crrev.com/cba509edaa5efe5a97ead7687c7cbac363d640ff Cr-Commit-Position: refs/heads/master@{#342526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Re-enable ChannelMojo.
5 years, 4 months ago (2015-08-08 14:29:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285463002/1
5 years, 4 months ago (2015-08-08 14:29:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-08 14:30:14 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 14:30:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cba509edaa5efe5a97ead7687c7cbac363d640ff
Cr-Commit-Position: refs/heads/master@{#342526}

Powered by Google App Engine
This is Rietveld 408576698