Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285443002: move V2 classes in chrome/engine to syncer_v2 namespace (Closed)

Created:
5 years, 4 months ago by stanisc
Modified:
5 years, 4 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move V2 classes in chrome/engine to syncer_v2 namespace BUG=516512 Committed: https://crrev.com/96665bd16904214c738e7edf6fe7399ae83b9146 Cr-Commit-Position: refs/heads/master@{#343452}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -541 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/non_blocking_data_type_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/non_blocking_data_type_controller.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M components/sync_driver/non_blocking_data_type_controller_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/sync_driver/non_blocking_data_type_manager.h View 2 chunks +2 lines, -5 lines 0 comments Download
M components/sync_driver/non_blocking_data_type_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/entity_tracker.h View 3 chunks +3 lines, -6 lines 0 comments Download
M sync/engine/entity_tracker.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M sync/engine/entity_tracker_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M sync/engine/model_type_entity.h View 2 chunks +1 line, -4 lines 0 comments Download
M sync/engine/model_type_entity.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/engine/model_type_entity_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M sync/engine/model_type_sync_proxy.h View 2 chunks +6 lines, -6 lines 0 comments Download
M sync/engine/model_type_sync_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/model_type_sync_proxy_impl.h View 8 chunks +13 lines, -20 lines 0 comments Download
M sync/engine/model_type_sync_proxy_impl.cc View 12 chunks +27 lines, -33 lines 0 comments Download
M sync/engine/model_type_sync_proxy_impl_unittest.cc View 24 chunks +48 lines, -63 lines 0 comments Download
M sync/engine/model_type_sync_worker.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sync/engine/model_type_sync_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/model_type_sync_worker_impl.h View 5 chunks +25 lines, -26 lines 0 comments Download
M sync/engine/model_type_sync_worker_impl.cc View 12 chunks +33 lines, -28 lines 0 comments Download
M sync/engine/model_type_sync_worker_impl_unittest.cc View 33 chunks +67 lines, -75 lines 0 comments Download
M sync/engine/non_blocking_type_commit_contribution.h View 3 chunks +4 lines, -4 lines 0 comments Download
M sync/engine/non_blocking_type_commit_contribution.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M sync/internal_api/public/sync_context.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sync/internal_api/public/sync_context_proxy.h View 2 chunks +2 lines, -5 lines 0 comments Download
M sync/internal_api/public/test/null_sync_context_proxy.h View 2 chunks +6 lines, -8 lines 0 comments Download
M sync/internal_api/sync_context_proxy_impl.h View 2 chunks +6 lines, -10 lines 0 comments Download
M sync/internal_api/sync_context_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_context_proxy_impl_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M sync/internal_api/test/null_sync_context_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/model_type_registry.h View 4 chunks +4 lines, -4 lines 0 comments Download
M sync/sessions/model_type_registry.cc View 9 chunks +32 lines, -45 lines 0 comments Download
M sync/sessions/model_type_registry_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/test/engine/injectable_sync_context_proxy.h View 1 chunk +8 lines, -9 lines 0 comments Download
M sync/test/engine/injectable_sync_context_proxy.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_proxy.h View 4 chunks +28 lines, -39 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_proxy.cc View 10 chunks +33 lines, -37 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_worker.h View 4 chunks +10 lines, -11 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_worker.cc View 10 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285443002/20001
5 years, 4 months ago (2015-08-13 19:26:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 20:38:42 UTC) #5
stanisc
PTAL!
5 years, 4 months ago (2015-08-13 20:53:07 UTC) #7
pavely
lgtm
5 years, 4 months ago (2015-08-14 17:58:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285443002/20001
5 years, 4 months ago (2015-08-14 18:54:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-14 18:59:24 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 18:59:53 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/96665bd16904214c738e7edf6fe7399ae83b9146
Cr-Commit-Position: refs/heads/master@{#343452}

Powered by Google App Engine
This is Rietveld 408576698