Reland 0c7d94eb9d9fa388bda0d74405c0928dceea22ff: Add support for tar.gz archive files to download f…

Reland 0c7d94eb9d9fa388bda0d74405c0928dceea22ff: Add support for tar.gz archive files to download from download_from_google_storage

I fixed the overlapping argument and fixed up the tests so that the actual sha1 hash is now passed (since the tool actually check now that the downloaded file hash matches)

BUG=
R=hinoka@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=296346

[ricow1, 2015-08-13 14:35:36]

ricow@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2015-08-13 16:12:11]

lgtm

https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
File tests/download_from_google_storage_unittests.py (right):

https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
tests/download_from_google_storage_unittests.py:69: class
ChangedWorkingDirectory(object):
I'm pretty sure would be racy if this test was run as part of a larger test
framework.  But this runs in serial so this is okay.

[ricow1, 2015-08-13 16:15:20]

The CQ bit was checked by ricow@google.com

[commit-bot: I haz the power, 2015-08-13 16:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285423002/20001

[commit-bot: I haz the power, 2015-08-13 16:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 16:20:37]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[ricow1, 2015-08-14 06:31:13]

Ryan: How should I go about landing this?

https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
File tests/download_from_google_storage_unittests.py (right):

https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
tests/download_from_google_storage_unittests.py:19: sys.path.insert(0,
os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
This is the reason why PRESUBMIT is failing. pylint ignores this, and simply
finds download_from_google_storage in the depot_tools where it is running from
(I don't know how PYTHONPATH is set for that, but at least it is wrong). I get
the same presubmit errors on upload, but if I run git cl upload from the depot
tools actually containing the changes no errors occur (by appending $PWD in the
beginning of $PATH).

[ricow1, 2015-08-17 08:18:06]

On 2015/08/14 06:31:13, ricow1 wrote:
> Ryan: How should I go about landing this?
pylint succeeds if run manually, should I just dcommit this?

> 
>
https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
> File tests/download_from_google_storage_unittests.py (right):
> 
>
https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
> tests/download_from_google_storage_unittests.py:19: sys.path.insert(0,
> os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
> This is the reason why PRESUBMIT is failing. pylint ignores this, and simply
> finds download_from_google_storage in the depot_tools where it is running from
> (I don't know how PYTHONPATH is set for that, but at least it is wrong). I get
> the same presubmit errors on upload, but if I run git cl upload from the depot
> tools actually containing the changes no errors occur (by appending $PWD in
the
> beginning of $PATH).

[hinoka, 2015-08-17 16:34:32]

Yeah just dcommit this.  If that assessment is correct it shouldn't break
presubmit since both copies of depot_tools would be updated.

On Mon, Aug 17, 2015 at 1:18 AM, <ricow@google.com> wrote:

> On 2015/08/14 06:31:13, ricow1 wrote:
>
>> Ryan: How should I go about landing this?
>>
> pylint succeeds if run manually, should I just dcommit this?
>
>
>
>
>
>
https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
>
>> File tests/download_from_google_storage_unittests.py (right):
>>
>
>
>
>
https://codereview.chromium.org/1285423002/diff/20001/tests/download_from_goo...
>
>> tests/download_from_google_storage_unittests.py:19: sys.path.insert(0,
>> os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
>> This is the reason why PRESUBMIT is failing. pylint ignores this, and
>> simply
>> finds download_from_google_storage in the depot_tools where it is running
>> from
>> (I don't know how PYTHONPATH is set for that, but at least it is wrong).
>> I get
>> the same presubmit errors on upload, but if I run git cl upload from the
>> depot
>> tools actually containing the changes no errors occur (by appending $PWD
>> in
>>
> the
>
>> beginning of $PATH).
>>
>
>
>
> https://codereview.chromium.org/1285423002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ricow1, 2015-08-18 05:53:59]

Committed patchset #2 (id:20001) manually as 296346.