Make DOMWrapperWorld::DOMObjectHolderBase fast-allocated.

Source/bindings/core/v8/DOMWrapperWorld.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 enum WorldIdConstants {
     MainWorldId = 0,
     // Embedder isolated worlds can use IDs in [1, 1<<29).
     EmbedderWorldIdLimit = (1 << 29),
     PrivateScriptIsolatedWorldId,
     IsolatedWorldIdLimit,
     WorkerWorldId,
     TestingWorldId,
 };
 
+class DOMObjectHolderBase;
+template<typename T> class DOMObjectHolder;
+
 // This class represent a collection of DOM wrappers for a specific world.
 class CORE_EXPORT DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
 public:
     static PassRefPtr<DOMWrapperWorld> create(v8::Isolate*, int worldId = -1, int extensionGroup = -1);
 
     static const int mainWorldExtensionGroup = 0;
     static const int privateScriptIsolatedWorldExtensionGroup = 1;
     static PassRefPtr<DOMWrapperWorld> ensureIsolatedWorld(v8::Isolate*, int worldId, int extensionGroup);
     ~DOMWrapperWorld();
     void dispose();
@@ skipping 49 matching lines @@
     int worldId() const { return m_worldId; }
     int extensionGroup() const { return m_extensionGroup; }
     DOMDataStore& domDataStore() const { return *m_domDataStore; }
 
     static void setWorldOfInitializingWindow(DOMWrapperWorld* world)
     {
         ASSERT(isMainThread());
         worldOfInitializingWindow = world;
     }
 
-private:
-    class DOMObjectHolderBase {
-    public:
-        DOMObjectHolderBase(v8::Isolate* isolate, v8::Local<v8::Value> wrapper)
-            : m_wrapper(isolate, wrapper)
-            , m_world(0)
-        {
-        }
-        virtual ~DOMObjectHolderBase() { }
-
-        DOMWrapperWorld* world() const { return m_world; }
-        void setWorld(DOMWrapperWorld* world) { m_world = world; }
-        void setWeak(void (*callback)(const v8::WeakCallbackInfo<DOMObjectHolderBase>&))
-        {
-            m_wrapper.setWeak(this, callback);
-        }
-
-    private:
-        ScopedPersistent<v8::Value> m_wrapper;
-        DOMWrapperWorld* m_world;
-    };
-
-    template<typename T>
-    class DOMObjectHolder : public DOMObjectHolderBase {
-    public:
-        static PassOwnPtr<DOMObjectHolder<T>> create(v8::Isolate* isolate, T* object, v8::Local<v8::Value> wrapper)
-        {
-            return adoptPtr(new DOMObjectHolder(isolate, object, wrapper));
-        }
-
-    private:
-        DOMObjectHolder(v8::Isolate* isolate, T* object, v8::Local<v8::Value> wrapper)
-            : DOMObjectHolderBase(isolate, wrapper)
-            , m_object(object)
-        {
-        }
-
-        Persistent<T> m_object;
-    };
-
 public:
     template<typename T>
-    void registerDOMObjectHolder(v8::Isolate* isolate, T* object, v8::Local<v8::Value> wrapper)
-    {
-        registerDOMObjectHolderInternal(DOMObjectHolder<T>::create(isolate, object, wrapper));
-    }
+    void registerDOMObjectHolder(v8::Isolate*, T*, v8::Local<v8::Value>);
 
 private:
     DOMWrapperWorld(v8::Isolate*, int worldId, int extensionGroup);
 
     static void weakCallbackForDOMObjectHolder(const v8::WeakCallbackInfo<DOMObjectHolderBase>&);
     void registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolderBase>);
     void unregisterDOMObjectHolder(DOMObjectHolderBase*);
 
     static unsigned isolatedWorldCount;
     static DOMWrapperWorld* worldOfInitializingWindow;
 
     const int m_worldId;
     const int m_extensionGroup;
     OwnPtr<DOMDataStore> m_domDataStore;
     HashSet<OwnPtr<DOMObjectHolderBase>> m_domObjectHolders;
 };
 
 } // namespace blink
 
 #endif // DOMWrapperWorld_h