cc/layers/layer_unittest.cc - Issue 12854010: cc: Chromify animation_test_common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_unittest.cc

Issue 12854010: cc: Chromify animation_test_common (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed reviewer comments and drive-by also fixed nine patch layerImpl FIXMENAME Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer_unittest.cc

diff --git a/cc/layers/layer_unittest.cc b/cc/layers/layer_unittest.cc

index ff717dbd1670adc5885dd25e0cce6eaa4560152e..98b830bc5a42b251be53de685bc4764cd1e35779 100644

--- a/cc/layers/layer_unittest.cc

+++ b/cc/layers/layer_unittest.cc

@@ -658,7 +658,7 @@ TEST_F(LayerTest,

impl_layer->layer_animation_controller()->SetAnimationRegistrar(

registrar.get());

- addAnimatedTransformToController(*impl_layer->layer_animation_controller(),

+ AddAnimatedTransformToController(impl_layer->layer_animation_controller(),

1.0,

100);

@@ -672,7 +672,7 @@ TEST_F(LayerTest,

EXPECT_TRUE(impl_layer->LayerSurfacePropertyChanged());

impl_layer->ResetAllChangeTrackingForSubtree();

- addAnimatedTransformToController(*impl_layer->layer_animation_controller(),

+ AddAnimatedTransformToController(impl_layer->layer_animation_controller(),

1.0,

100);

@@ -696,7 +696,7 @@ TEST_F(LayerTest,

impl_layer->layer_animation_controller()->SetAnimationRegistrar(

registrar.get());

- addOpacityTransitionToController(*impl_layer->layer_animation_controller(),

+ AddOpacityTransitionToController(impl_layer->layer_animation_controller(),

1.0,

0.3f,

0.7f,

@@ -709,7 +709,7 @@ TEST_F(LayerTest,

EXPECT_TRUE(impl_layer->LayerSurfacePropertyChanged());

impl_layer->ResetAllChangeTrackingForSubtree();

- addOpacityTransitionToController(*impl_layer->layer_animation_controller(),

+ AddOpacityTransitionToController(impl_layer->layer_animation_controller(),

1.0,

0.3f,

0.7f,