Chromium Code Reviews

Issue 1285373007: Revert of Convert ChromeSyncShell to use ChromePublic infrastructure (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
newt (away), jbudorick, pval...(no longer on Chromium)
CC:
chromium-reviews, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert ChromeSyncShell to use ChromePublic infrastructure (patchset #7 id:120001 of https://codereview.chromium.org/1282603005/ ) Reason for revert: broke ChromeSyncShell build. http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/22336/steps/compile/logs/stdio Original issue's description: > Convert ChromeSyncShell to use ChromePublic infrastructure > > Several test fixes are included to support this change. > > Note: This CL only provides a GYP implementation (no GN). This is not a > regression from the previous state. > > BUG=510211 > > Committed: https://crrev.com/62ca3f0326203cca221bba6f0ee038ff292ecc66 > Cr-Commit-Position: refs/heads/master@{#344128} TBR=jbudorick@chromium.org,newt@chromium.org,pvalenzuela@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510211 Committed: https://crrev.com/ec748bc5560f56d838178b07313e59bd4136f7ee Cr-Commit-Position: refs/heads/master@{#344137}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+485 lines, -332 lines)
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments
M chrome/android/BUILD.gn View 3 chunks +69 lines, -0 lines 0 comments
M chrome/android/chrome_apk.gyp View 8 chunks +12 lines, -170 lines 0 comments
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 1 chunk +0 lines, -1 line 0 comments
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 2 chunks +0 lines, -2 lines 0 comments
A chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +25 lines, -0 lines 0 comments
A chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc View 1 chunk +39 lines, -0 lines 0 comments
A chrome/android/sync_shell/java/AndroidManifest.xml.jinja2 View 1 chunk +158 lines, -0 lines 0 comments
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 2 chunks +15 lines, -17 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 2 chunks +0 lines, -3 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 4 chunks +22 lines, -12 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 7 chunks +36 lines, -35 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 3 chunks +4 lines, -4 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 4 chunks +12 lines, -18 lines 0 comments
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/android/DEPS View 1 chunk +0 lines, -1 line 0 comments
D chrome/browser/android/chrome_sync_shell_main_delegate.h View 1 chunk +0 lines, -25 lines 0 comments
D chrome/browser/android/chrome_sync_shell_main_delegate.cc View 1 chunk +0 lines, -24 lines 0 comments
D chrome/browser/android/chrome_sync_shell_main_delegate_initializer.cc View 1 chunk +0 lines, -10 lines 0 comments
M chrome/chrome_shell.gypi View 2 chunks +65 lines, -0 lines 0 comments
M chrome/chrome_tests.gypi View 1 chunk +25 lines, -0 lines 0 comments
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 4 chunks +0 lines, -4 lines 0 comments
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 3 chunks +0 lines, -3 lines 0 comments

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Convert ChromeSyncShell to use ChromePublic infrastructure
5 years, 4 months ago (2015-08-19 03:17:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285373007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285373007/1
5 years, 4 months ago (2015-08-19 03:17:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 03:18:32 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:19:21 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ec748bc5560f56d838178b07313e59bd4136f7ee
Cr-Commit-Position: refs/heads/master@{#344137}

Powered by Google App Engine