Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285373004: Elim unused Chrome OS networking UI code (Closed)

Created:
5 years, 4 months ago by stevenjb
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_516796_third_party_vpn_alt_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim unused Chrome OS networking UI code BUG=none Committed: https://crrev.com/948821a87b07c02743845cb2158c46ab43615eb6 Cr-Commit-Position: refs/heads/master@{#343852}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -84 lines) Patch
M chrome/browser/resources/options/chromeos/internet_detail.html View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 4 chunks +2 lines, -59 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chromeos/network/network_util.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/network/network_util.cc View 2 chunks +1 line, -10 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
stevenjb
5 years, 4 months ago (2015-08-13 23:46:23 UTC) #2
pneubeck (no reviews)
lgtm
5 years, 4 months ago (2015-08-14 07:08:04 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1292053004 Patch 1). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-14 15:33:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285373004/20001
5 years, 4 months ago (2015-08-17 21:24:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99275)
5 years, 4 months ago (2015-08-18 00:14:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285373004/20001
5 years, 4 months ago (2015-08-18 07:15:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 07:56:20 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:57:24 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/948821a87b07c02743845cb2158c46ab43615eb6
Cr-Commit-Position: refs/heads/master@{#343852}

Powered by Google App Engine
This is Rietveld 408576698