Ensure that Service Worker clients are always returned in MRU order (1)

content/browser/service_worker/service_worker_provider_host.cc

Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index 5be3d96c8aeb8168a24be2c5fcd9ba018d644104..63c1b357742c9ed2695ae1064fa4f602513e1247 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -442,16 +442,18 @@ ServiceWorkerClientInfo ServiceWorkerProviderHost::GetWindowClientInfoOnUI(
       RenderFrameHostImpl::FromID(render_process_id, render_frame_id);
   if (!render_frame_host)
     return ServiceWorkerClientInfo();
+  WebContents* web_contents =
+      WebContents::FromRenderFrameHost(render_frame_host);
 
   // TODO(mlamouri,michaeln): it is possible to end up collecting information
   // for a frame that is actually being navigated and isn't exactly what we are
   // expecting.
   return ServiceWorkerClientInfo(
-      render_frame_host->GetVisibilityState(),
-      render_frame_host->IsFocused(),
+      render_frame_host->GetVisibilityState(), render_frame_host->IsFocused(),
       render_frame_host->GetLastCommittedURL(),
       render_frame_host->GetParent() ? REQUEST_CONTEXT_FRAME_TYPE_NESTED
                                      : REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL,
+      web_contents ? web_contents->GetLastActiveTime() : base::TimeTicks(),

[falken, 2015/08/17 06:28:32]

I'm curious when web_contents would be null? Anyone knows?

[jeremyarcher, 2015/08/17 06:51:57]

I'm honestly not sure- the comment below in web_contents.h suggests so, but that
might be less necessary post-split.

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

       blink::WebServiceWorkerClientTypeWindow);
 }