content/browser/service_worker/service_worker_version.cc - Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basic patch (no tests) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | content/common/service_worker/service_worker_client_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 5415d33b9df232571a4495951aee5fd81e5ec295..db516304b82b325d2cabfa62b5953ae04550d894 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -378,10 +378,11 @@ void AddNonWindowClient(ServiceWorkerProviderHost* host,

options.client_type != host_client_type)

return;

- ServiceWorkerClientInfo client_info(

- blink::WebPageVisibilityStateHidden,

- false, // is_focused

- host->document_url(), REQUEST_CONTEXT_FRAME_TYPE_NONE, host_client_type);

+ ServiceWorkerClientInfo client_info(blink::WebPageVisibilityStateHidden,

+ false, // is_focused

+ host->document_url(),

+ REQUEST_CONTEXT_FRAME_TYPE_NONE,

+ base::TimeTicks::Now(), host_client_type);

nhiroki 2015/08/13 05:56:31 Non-window clients seem to always overcome window

jeremyarcher 2015/08/14 05:22:05 Fixed.

client_info.client_uuid = host->client_uuid();

clients->push_back(client_info);

}

@@ -1297,6 +1298,7 @@ void ServiceWorkerVersion::OnGetClientsFinished(

if (running_status() != RUNNING)

return;

+ std::sort(clients);

nhiroki 2015/08/13 05:56:31 Can you add comments about why we sort clients her

jeremyarcher 2015/08/14 05:22:05 Fixed.

embedded_worker_->SendMessage(

ServiceWorkerMsg_DidGetClients(request_id, clients));

}