content/browser/service_worker/service_worker_version.h - Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix inconsistencies. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 7a7c38fab69dc4ac8236118bbfa20048c70f79d1..04e3a406b56bc2af83bac01e63f1e9b3d322be66 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -496,8 +496,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

void GetNonWindowClients(int request_id,

const ServiceWorkerClientQueryOptions& options,

ServiceWorkerClients* clients);

- void OnGetClientsFinished(int request_id,

- const ServiceWorkerClients& clients);

+ void OnGetClientsFinished(int request_id, ServiceWorkerClients* clients);

// The timeout timer periodically calls OnTimeoutTimer, which stops the worker

// if it is excessively idle or unresponsive to ping.