content/browser/service_worker/service_worker_provider_host.cc - Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move focus handling machinery to FocusTreeNode and fix capitalization. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_node.h ('K') | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index ac0ef3fcdfc585756489f2ebc6e74d870178c9e2..708d7487c53d4624f08ccd102091f3533325d8de 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -443,11 +443,11 @@ ServiceWorkerClientInfo ServiceWorkerProviderHost::GetWindowClientInfoOnUI(

// for a frame that is actually being navigated and isn't exactly what we are

// expecting.

return ServiceWorkerClientInfo(

- render_frame_host->GetVisibilityState(),

- render_frame_host->IsFocused(),

+ render_frame_host->GetVisibilityState(), render_frame_host->IsFocused(),

render_frame_host->GetLastCommittedURL(),

render_frame_host->GetParent() ? REQUEST_CONTEXT_FRAME_TYPE_NESTED

: REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL,

+ render_frame_host->frame_tree_node()->last_focus_time(),

blink::WebServiceWorkerClientTypeWindow);

}