Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch from activate to focus for ordering. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index ac0ef3fcdfc585756489f2ebc6e74d870178c9e2..9698f75b0a9f22140cdacbf0c459f635b5c4d381 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -438,16 +438,19 @@ ServiceWorkerClientInfo ServiceWorkerProviderHost::GetWindowClientInfoOnUI(
RenderFrameHostImpl::FromID(render_process_id, render_frame_id);
if (!render_frame_host)
return ServiceWorkerClientInfo();
+ RenderWidgetHost* render_widget_host =
+ render_frame_host->GetRenderWidgetHost();
nhiroki 2015/08/19 03:45:50 I wonder if we can call LastFocusTime() w/o exposi
// TODO(mlamouri,michaeln): it is possible to end up collecting information
// for a frame that is actually being navigated and isn't exactly what we are
// expecting.
return ServiceWorkerClientInfo(
- render_frame_host->GetVisibilityState(),
- render_frame_host->IsFocused(),
+ render_frame_host->GetVisibilityState(), render_frame_host->IsFocused(),
render_frame_host->GetLastCommittedURL(),
render_frame_host->GetParent() ? REQUEST_CONTEXT_FRAME_TYPE_NESTED
: REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL,
+ render_widget_host ? render_widget_host->LastFocusTime()
+ : base::TimeTicks(),
blink::WebServiceWorkerClientTypeWindow);
}
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698