Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: content/common/service_worker/service_worker_client_info.cc

Issue 1285373002: Ensure that Service Worker clients are always returned in MRU order (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typos and add comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/service_worker/service_worker_client_info.h" 5 #include "content/common/service_worker/service_worker_client_info.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/common/service_worker/service_worker_types.h" 8 #include "content/common/service_worker/service_worker_types.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 ServiceWorkerClientInfo::ServiceWorkerClientInfo() 12 ServiceWorkerClientInfo::ServiceWorkerClientInfo()
13 : page_visibility_state(blink::WebPageVisibilityStateLast), 13 : page_visibility_state(blink::WebPageVisibilityStateLast),
14 is_focused(false), 14 is_focused(false),
15 frame_type(REQUEST_CONTEXT_FRAME_TYPE_LAST), 15 frame_type(REQUEST_CONTEXT_FRAME_TYPE_LAST),
16 client_type(blink::WebServiceWorkerClientTypeLast) { 16 client_type(blink::WebServiceWorkerClientTypeLast),
17 } 17 last_active_time(base::TimeTicks()) {}
18
19 ServiceWorkerClientInfo::ServiceWorkerClientInfo(
20 const ServiceWorkerClientInfo& a) = default;
18 21
19 ServiceWorkerClientInfo::ServiceWorkerClientInfo( 22 ServiceWorkerClientInfo::ServiceWorkerClientInfo(
20 blink::WebPageVisibilityState page_visibility_state, 23 blink::WebPageVisibilityState page_visibility_state,
21 bool is_focused, 24 bool is_focused,
22 const GURL& url, 25 const GURL& url,
23 RequestContextFrameType frame_type, 26 RequestContextFrameType frame_type,
27 base::TimeTicks last_active_time,
24 blink::WebServiceWorkerClientType client_type) 28 blink::WebServiceWorkerClientType client_type)
25 : page_visibility_state(page_visibility_state), 29 : page_visibility_state(page_visibility_state),
26 is_focused(is_focused), 30 is_focused(is_focused),
27 url(url), 31 url(url),
28 frame_type(frame_type), 32 frame_type(frame_type),
29 client_type(client_type) { 33 client_type(client_type),
30 } 34 last_active_time(last_active_time) {}
31 35
32 bool ServiceWorkerClientInfo::IsEmpty() const { 36 bool ServiceWorkerClientInfo::IsEmpty() const {
33 return page_visibility_state == blink::WebPageVisibilityStateLast && 37 return page_visibility_state == blink::WebPageVisibilityStateLast &&
34 is_focused == false && 38 is_focused == false &&
35 url.is_empty() && 39 url.is_empty() &&
36 frame_type == REQUEST_CONTEXT_FRAME_TYPE_LAST && 40 frame_type == REQUEST_CONTEXT_FRAME_TYPE_LAST &&
37 client_type == blink::WebServiceWorkerClientTypeLast; 41 client_type == blink::WebServiceWorkerClientTypeLast;
38 } 42 }
39 43
40 bool ServiceWorkerClientInfo::IsValid() const { 44 bool ServiceWorkerClientInfo::IsValid() const {
41 return !IsEmpty() && !client_uuid.empty(); 45 return !IsEmpty() && !client_uuid.empty();
42 } 46 }
43 47
44 } // namespace content 48 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698