Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1285363003: Fix UserSessionManager::Shutdown ordering. (Closed)

Created:
5 years, 4 months ago by achuithb
Modified:
5 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UserSessionManager::Shutdown ordering. UserSessionManager::Shutdown calls ~TokenHandleFetcher. ~TokenHandleFetcher sometimes calls ProfileOAuth2TokenService when there's a pending request. ProfileOAuth2TokenService is a profile KeyedService that gets deleted when ProfileImpls are deleted. ProfileImpls are owned by ProfileManager, which is owned by BrowserProcess, and these get deleted in BrowserProcessImpl::StartTearDown, which is called by ChromeBrowserMainParts::PostMainMessageLoopRun. Hence UserSessionManager::Shutdown must be called before PostMainMessageLoopRun, otherwise we have crashes when UserSessionManager::token_handle_fetcher_ is not null, and there are pending refresh token requests. BUG=510997 Committed: https://crrev.com/ceda654bae23888a8489fd46d46cdb7a8d8fe6b9 Cr-Commit-Position: refs/heads/master@{#343318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
achuithb
Xiyuan, what do you think?
5 years, 4 months ago (2015-08-14 00:18:31 UTC) #2
achuithb
Denis for FYI, seems to be OOO
5 years, 4 months ago (2015-08-14 00:21:27 UTC) #4
xiyuan
lgtm
5 years, 4 months ago (2015-08-14 01:01:50 UTC) #5
achuithb
On 2015/08/14 01:01:50, xiyuan wrote: > lgtm Ty
5 years, 4 months ago (2015-08-14 01:19:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285363003/1
5 years, 4 months ago (2015-08-14 01:20:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 02:00:20 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ceda654bae23888a8489fd46d46cdb7a8d8fe6b9 Cr-Commit-Position: refs/heads/master@{#343318}
5 years, 4 months ago (2015-08-14 02:00:54 UTC) #10
achuithb
5 years, 4 months ago (2015-08-14 19:30:10 UTC) #12
Message was sent while issue was closed.
+Ilja for fyi

Powered by Google App Engine
This is Rietveld 408576698