DescriptionFix UserSessionManager::Shutdown ordering.
UserSessionManager::Shutdown calls ~TokenHandleFetcher.
~TokenHandleFetcher sometimes calls ProfileOAuth2TokenService when there's a
pending request.
ProfileOAuth2TokenService is a profile KeyedService that gets deleted when
ProfileImpls are deleted.
ProfileImpls are owned by ProfileManager, which is owned by BrowserProcess,
and these get deleted in BrowserProcessImpl::StartTearDown, which is called
by ChromeBrowserMainParts::PostMainMessageLoopRun.
Hence UserSessionManager::Shutdown must be called before PostMainMessageLoopRun,
otherwise we have crashes when UserSessionManager::token_handle_fetcher_
is not null, and there are pending refresh token requests.
BUG=510997
Committed: https://crrev.com/ceda654bae23888a8489fd46d46cdb7a8d8fe6b9
Cr-Commit-Position: refs/heads/master@{#343318}
Patch Set 1 #
Messages
Total messages: 12 (4 generated)
|