chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 1285313003: [Offline pages] Wiring saving and opening offline page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1285313003: [Offline pages] Wiring saving and opening offline page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address more feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModelTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index db6f47a00df14fe3b76eff9a3e6a1bbdba46c9d1..118997555a5d2d3e0a46998507bcd0f83827f0b0 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -37,7 +37,7 @@ void SavePageCallback(ScopedJavaGlobalRef<jobject>* j_callback_obj,

scoped_ptr<ScopedJavaGlobalRef<jobject>> j_callback_ptr(j_callback_obj);

- Java_OfflinePageCallback_onSavePageDone(

+ Java_SavePageCallback_onSavePageDone(

env, j_callback_ptr->obj(), static_cast<int>(result),

ConvertUTF8ToJavaString(env, url.spec()).obj());

}

@@ -48,7 +48,7 @@ void DeletePageCallback(ScopedJavaGlobalRef<jobject>* j_callback_obj,

scoped_ptr<ScopedJavaGlobalRef<jobject>> j_callback_ptr(j_callback_obj);

- Java_OfflinePageCallback_onDeletePageDone(

+ Java_DeletePageCallback_onDeletePageDone(

env, j_callback_ptr->obj(), static_cast<int>(result));

}