Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java

Issue 1285313003: [Offline pages] Wiring saving and opening offline page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java
index d4c5c63d35f4eacf55b90df4d15d91aaf8adcab6..b2f71692d37c87bd622697d54c7742c2b73988bd 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridgeTest.java
@@ -8,8 +8,9 @@ import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ThreadUtils;
import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.offline_pages.OfflinePageBridge.OfflinePageCallback;
+import org.chromium.chrome.browser.offline_pages.OfflinePageBridge.DeletePageCallback;
import org.chromium.chrome.browser.offline_pages.OfflinePageBridge.OfflinePageModelObserver;
+import org.chromium.chrome.browser.offline_pages.OfflinePageBridge.SavePageCallback;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
import org.chromium.chrome.test.util.TestHttpServerClient;
@@ -128,7 +129,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
getActivity().getActivityTab().getWebContents());
mOfflinePageBridge.savePage(getActivity().getActivityTab().getWebContents(),
- BOOKMARK_ID, new OfflinePageCallback() {
+ BOOKMARK_ID, new SavePageCallback() {
@Override
public void onSavePageDone(int savePageResult, String url) {
assertEquals(
@@ -137,10 +138,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
"Save result incorrect.", expectedResult, savePageResult);
semaphore.release();
}
-
- @Override
- public void onDeletePageDone(int deletePageResult) {
- }
});
}
});
@@ -153,11 +150,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- mOfflinePageBridge.deletePage(BOOKMARK_ID, new OfflinePageCallback() {
- @Override
- public void onSavePageDone(int savePageResult, String url) {
- }
-
+ mOfflinePageBridge.deletePage(BOOKMARK_ID, new DeletePageCallback() {
@Override
public void onDeletePageDone(int deletePageResult) {
assertEquals(

Powered by Google App Engine
This is Rietveld 408576698