[Offline pages] Wiring saving and opening offline page

chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java

Index: chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
index abb5f5018ef8e653519c16c6b2e44559ec7c39d8..d21728a20eed9b35ca39f7257298ceea7dd9831c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
@@ -31,9 +31,9 @@ public final class OfflinePageBridge {
     private static Boolean sIsEnabled;
 
     /**
-     * Interface with callbacks to public calls on OfflinePageBrdige.
+     * Callback used to saving an offline page.
      */
-    public interface OfflinePageCallback {
+    public interface SavePageCallback {
         /**
          * Delivers result of saving a page.
          *
@@ -42,9 +42,14 @@ public final class OfflinePageBridge {
          * @param url URL of the saved page.
          * @see OfflinePageBridge#savePage()

[fgorski, 2015/08/13 17:41:51]

nit: you can move that to interface comment, as the whole interface applies to a
single method.
Same below.

[jianli, 2015/08/13 22:37:18]

I rather still keep it here since the comment for params still make more sense
to the individual method.

          */
-        @CalledByNative("OfflinePageCallback")
+        @CalledByNative("SavePageCallback")
         void onSavePageDone(int savePageResult, String url);
+    }
 
+    /**
+     * Callback used to deleting an offline page.
+     */
+    public interface DeletePageCallback {
         /**
          * Delivers result of deleting a page.
          *
@@ -52,7 +57,7 @@ public final class OfflinePageBridge {
          *     {@see org.chromium.components.offline_pages.DeletePageResult} enum.
          * @see OfflinePageBridge#deletePage()
          */
-        @CalledByNative("OfflinePageCallback")
+        @CalledByNative("DeletePageCallback")
         void onDeletePageDone(int deletePageResult);
     }
 
@@ -143,11 +148,11 @@ public final class OfflinePageBridge {
      * @param webContents Contents of the page to save.
      * @param bookmarkId Id of the bookmark related to the offline page.
      * @param callback Interface that contains a callback.
-     * @see OfflinePageCallback
+     * @see SavePageCallback
      */
     @VisibleForTesting
     public void savePage(
-            WebContents webContents, BookmarkId bookmarkId, OfflinePageCallback callback) {
+            WebContents webContents, BookmarkId bookmarkId, SavePageCallback callback) {
         assert mIsNativeOfflinePageModelLoaded;
         nativeSavePage(mNativeOfflinePageBridge, callback, webContents, bookmarkId.getId());
     }
@@ -157,9 +162,10 @@ public final class OfflinePageBridge {
      *
      * @param bookmarkId Bookmark ID for which the offline copy will be deleted.
      * @param callback Interface that contains a callback.
+     * @see DeletePageCallback
      */
     @VisibleForTesting
-    public void deletePage(BookmarkId bookmarkId, OfflinePageCallback callback) {
+    public void deletePage(BookmarkId bookmarkId, DeletePageCallback callback) {
         assert mIsNativeOfflinePageModelLoaded;
         nativeDeletePage(mNativeOfflinePageBridge, callback, bookmarkId.getId());
     }
@@ -199,8 +205,8 @@ public final class OfflinePageBridge {
             long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
     private native OfflinePageItem nativeGetPageByBookmarkId(
             long nativeOfflinePageBridge, long bookmarkId);
-    private native void nativeSavePage(long nativeOfflinePageBridge, OfflinePageCallback callback,
+    private native void nativeSavePage(long nativeOfflinePageBridge, SavePageCallback callback,
             WebContents webContents, long bookmarkId);
     private native void nativeDeletePage(long nativeOfflinePageBridge,
-            OfflinePageCallback callback, long bookmarkId);
+            DeletePageCallback callback, long bookmarkId);
 }