[Offline pages] Wiring saving and opening offline page

chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
index f2f936ca62617c79ab84fbc9d1b12ac3e7e9e9a8..8ea7bb1a065251b271da2bb016545dfec9af8ef1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
@@ -394,11 +394,13 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
     public void openBookmark(BookmarkId bookmark, int launchLocation) {
         clearSelection();
         if (mEnhancedBookmarksModel.getBookmarkById(bookmark) != null) {
+            String url = mEnhancedBookmarksModel.getBookmarkLaunchUrl(bookmark);
+            if (url == null || url.isEmpty()) return;

[Kibeom Kim (inactive), 2015/08/13 20:43:48]

nit: there is a handy util function for this pattern: TextUtils.isEmpty(url);

Q: when can this happen? And if it happens, do we want to notify user that the
launching is failed in some way?

[jianli, 2015/08/13 22:37:18]

Done.
This could happen when the offline page metadata has been deleted or corrupted.
What do we want to notify the user? I think we're already hitting this for line
396. I added a TODO here.

+
             NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);
             RecordHistogram.recordEnumeratedHistogram("Stars.LaunchLocation", launchLocation,
                     LaunchLocation.COUNT);
-            EnhancedBookmarkUtils.openBookmark(mActivity,
-                    mEnhancedBookmarksModel.getBookmarkById(bookmark).getUrl());
+            EnhancedBookmarkUtils.openBookmark(mActivity, url);
             finishActivityOnPhone();
         }
     }