Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/renderer/extensions/extension_helper.h

Issue 12853007: Don't throw exceptions when v8 objects/contexts are missing, and catch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable test #2 Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/console.cc ('k') | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/extension_helper.h
diff --git a/chrome/renderer/extensions/extension_helper.h b/chrome/renderer/extensions/extension_helper.h
index a1d934c9581b41ba838208ef4cafb664961fa6d3..d9a303e49b34d34e4bdb2dbb02419c2ae794bb7d 100644
--- a/chrome/renderer/extensions/extension_helper.h
+++ b/chrome/renderer/extensions/extension_helper.h
@@ -56,10 +56,7 @@ class ExtensionHelper
int tab_id() const { return tab_id_; }
int browser_window_id() const { return browser_window_id_; }
chrome::ViewType view_type() const { return view_type_; }
-
- // Helper to add a logging message to the root frame's console.
- void AddMessageToRootConsole(content::ConsoleMessageLevel level,
- const std::string& message);
+ Dispatcher* dispatcher() const { return dispatcher_; }
private:
// RenderViewObserver implementation.
@@ -99,10 +96,6 @@ class ExtensionHelper
const std::string& message);
void OnAppWindowClosed();
- // Helper to add a logging message to the root frame's console.
- void AddMessageToRootConsole(content::ConsoleMessageLevel level,
- const string16& message);
-
Dispatcher* dispatcher_;
// The app info that we are processing. This is used when installing an app
« no previous file with comments | « chrome/renderer/extensions/console.cc ('k') | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698