Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8279)

Unified Diff: chrome/renderer/extensions/module_system.h

Issue 12853007: Don't throw exceptions when v8 objects/contexts are missing, and catch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/module_system.h
diff --git a/chrome/renderer/extensions/module_system.h b/chrome/renderer/extensions/module_system.h
index 9f3d602600fba167384da20ccbf8a49e1a6e86d1..09130a067798578ac88c4ebc6220bb6b7e62f09a 100644
--- a/chrome/renderer/extensions/module_system.h
+++ b/chrome/renderer/extensions/module_system.h
@@ -168,7 +168,7 @@ class ModuleSystem : public ObjectBackedNativeHandler {
// Return the named source file stored in the source map.
// |args[0]| - the name of a source file in source_map_.
- v8::Handle<v8::Value> GetSource(v8::Handle<v8::String> source_name);
+ v8::Handle<v8::Value> GetSource(const std::string& module_name);
// Return an object that contains the native methods defined by the named
// NativeHandler.
@@ -179,9 +179,6 @@ class ModuleSystem : public ObjectBackedNativeHandler {
// Wraps |source| in a (function(require, requireNative, exports) {...}).
v8::Handle<v8::String> WrapSource(v8::Handle<v8::String> source);
- // Throws an exception in the calling JS context.
- v8::Handle<v8::Value> ThrowException(const std::string& message);
-
// A map from module names to the JS source for that module. GetSource()
// performs a lookup on this map.
SourceMap* source_map_;

Powered by Google App Engine
This is Rietveld 408576698