Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/webdata/web_data_service_base.cc

Issue 12853004: Move creation of WebDatabaseTable subclasses to WebDatabaseServiceFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix path snafu. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service_base.cc
diff --git a/chrome/browser/webdata/web_data_service_base.cc b/chrome/browser/webdata/web_data_service_base.cc
index 57891aa14de24c57797554b5410367fb517dbe7b..25b1e721674f9d1525ff4d2d9d15f5aae20cad7c 100644
--- a/chrome/browser/webdata/web_data_service_base.cc
+++ b/chrome/browser/webdata/web_data_service_base.cc
@@ -29,8 +29,10 @@ using base::Bind;
using base::Time;
using content::BrowserThread;
-WebDataServiceBase::WebDataServiceBase(const ProfileErrorCallback& callback)
+WebDataServiceBase::WebDataServiceBase(const base::FilePath& path,
+ const ProfileErrorCallback& callback)
: db_loaded_(false),
+ path_(path),
profile_error_callback_(callback) {
// WebDataService requires DB thread if instantiated.
// Set WebDataServiceFactory::GetInstance()->SetTestingFactory(&profile, NULL)
@@ -46,8 +48,14 @@ void WebDataServiceBase::ShutdownOnUIThread() {
ShutdownDatabase();
}
-void WebDataServiceBase::Init(const base::FilePath& path) {
- wdbs_.reset(new WebDatabaseService(path));
+void WebDataServiceBase::AddTable(scoped_ptr<WebDatabaseTable> table) {
+ if (!wdbs_.get())
+ wdbs_.reset(new WebDatabaseService(path_));
+ wdbs_->AddTable(table.Pass());
+}
+
+void WebDataServiceBase::Init() {
+ DCHECK(wdbs_.get());
wdbs_->LoadDatabase(Bind(&WebDataServiceBase::DatabaseInitOnDB, this));
}

Powered by Google App Engine
This is Rietveld 408576698