Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: runtime/vm/parser.cc

Issue 1285293004: Migrate most uses of StackZone(Isolate*) to Thread*. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Final cleanup. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.h ('k') | runtime/vm/runtime_entry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 3613166871cd1f5f83b92d16da9dbddc6c58c212..942f5c61fd1c29848f8907e668e7cbf15ac0ac8d 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -795,7 +795,7 @@ RawObject* Parser::ParseFunctionParameters(const Function& func) {
ASSERT(!func.IsNull());
Thread* thread = Thread::Current();
Isolate* isolate = thread->isolate();
- StackZone stack_zone(isolate);
+ StackZone stack_zone(thread);
Zone* zone = stack_zone.GetZone();
LongJumpScope jump;
if (setjmp(*jump.Set()) == 0) {
@@ -978,7 +978,7 @@ void Parser::ParseFunction(ParsedFunction* parsed_function) {
RawObject* Parser::ParseMetadata(const Class& cls, intptr_t token_pos) {
Thread* thread = Thread::Current();
Isolate* isolate = thread->isolate();
- StackZone stack_zone(isolate);
+ StackZone stack_zone(thread);
Zone* zone = stack_zone.GetZone();
LongJumpScope jump;
if (setjmp(*jump.Set()) == 0) {
@@ -1166,7 +1166,7 @@ RawObject* Parser::ParseFunctionFromSource(const Class& owning_class,
const String& source) {
Thread* thread = Thread::Current();
Isolate* isolate = thread->isolate();
- StackZone stack_zone(isolate);
+ StackZone stack_zone(thread);
LongJumpScope jump;
if (setjmp(*jump.Set()) == 0) {
const String& uri = String::Handle(Symbols::New("dynamically-added"));
@@ -12035,7 +12035,7 @@ bool Parser::ResolveIdentInLocalScope(intptr_t ident_pos,
AstNode* Parser::ResolveIdentInCurrentLibraryScope(intptr_t ident_pos,
const String& ident) {
TRACE_PARSER("ResolveIdentInCurrentLibraryScope");
- HANDLESCOPE(I);
+ HANDLESCOPE(thread());
const Object& obj = Object::Handle(Z, library_.ResolveName(ident));
if (obj.IsClass()) {
const Class& cls = Class::Cast(obj);
@@ -12082,7 +12082,7 @@ AstNode* Parser::ResolveIdentInPrefixScope(intptr_t ident_pos,
const LibraryPrefix& prefix,
const String& ident) {
TRACE_PARSER("ResolveIdentInPrefixScope");
- HANDLESCOPE(I);
+ HANDLESCOPE(thread());
if (ident.CharAt(0) == Library::kPrivateIdentifierStart) {
// Private names are not exported by libraries. The name mangling
// of private names with a library-specific suffix usually ensures
« no previous file with comments | « runtime/vm/parser.h ('k') | runtime/vm/runtime_entry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698