Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1285293003:
Remove ScopedStyleResolver::treeScopeFor. (Closed)
|
Created:
5 years, 4 months ago by esprehn Modified:
5 years, 4 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionRemove ScopedStyleResolver::treeScopeFor.
The ownerNode()'s treeScope() is always the scope of a stylesheet except for
document scoped sheets in imports which apply to the main document. We can
express this simpler without the set of checks in treeScopeFor.
Link elements and processing instructions also don't even get added as
candidates if they're not children of the Document so we don't need the type
checks, I've instead replaced them with asserts. There's also no way for us
have a null ownerDocument at the point where this code is called so I added
an assert for that too.
R=ojan@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200578
Patch Set 1 #Patch Set 2 : Apply sheets for html imports to the main document. #
Messages
Total messages: 39 (18 generated)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65985)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
esprehn@chromium.org changed reviewers: + rune@opera.com, timloh@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ping.
lgtm
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285293003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200578 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
