Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1285273004: Avoid floating point when calculating the actual column count. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Avoid floating point when calculating the actual column count. It's too inaccurate. BUG=502407 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200848

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
A + LayoutTests/fast/pagination/short-pages-tall-content.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/pagination/short-pages-tall-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 11 (2 generated)
mstensho (USE GERRIT)
https://codereview.chromium.org/1285273004/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp File Source/core/layout/MultiColumnFragmentainerGroup.cpp (right): https://codereview.chromium.org/1285273004/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp#newcode285 Source/core/layout/MultiColumnFragmentainerGroup.cpp:285: if (count * m_columnHeight < flowThreadPortionHeight) If you can ...
5 years, 4 months ago (2015-08-17 11:18:00 UTC) #1
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-17 20:21:16 UTC) #3
eae
LGTM https://codereview.chromium.org/1285273004/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp File Source/core/layout/MultiColumnFragmentainerGroup.cpp (right): https://codereview.chromium.org/1285273004/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp#newcode285 Source/core/layout/MultiColumnFragmentainerGroup.cpp:285: if (count * m_columnHeight < flowThreadPortionHeight) On 2015/08/17 ...
5 years, 4 months ago (2015-08-17 21:34:53 UTC) #4
leviw_travelin_and_unemployed
On 2015/08/17 at 21:34:53, eae wrote: > LGTM > > https://codereview.chromium.org/1285273004/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp > File Source/core/layout/MultiColumnFragmentainerGroup.cpp (right): ...
5 years, 4 months ago (2015-08-17 21:45:28 UTC) #5
mstensho (USE GERRIT)
On 2015/08/17 21:45:28, leviw wrote: > On 2015/08/17 at 21:34:53, eae wrote: > > LGTM ...
5 years, 4 months ago (2015-08-17 22:43:19 UTC) #6
mstensho (USE GERRIT)
5 years, 4 months ago (2015-08-19 19:18:29 UTC) #7
eae
This is fine, go for it. LGTM
5 years, 4 months ago (2015-08-19 19:49:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285273004/1
5 years, 4 months ago (2015-08-19 19:50:01 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 21:44:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200848

Powered by Google App Engine
This is Rietveld 408576698