DescriptionRevert of [Script Injection] Allow whitelisted extensions to inject scripts everywhere (patchset #2 id:40001 of https://codereview.chromium.org/1288893005/ )
Reason for revert:
Seems to have broken browser_tests on Windows-XP-SP3
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39547
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39546
[ RUN ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages
[416:2484:0818/104836:ERROR:shell_util.cc(1184)] Error getting short (8.3) path for E:\b\swarm_slave\work\run_tha_testyfglvj\out\Release\browser_tests.exe: The system cannot find the path specified. (0x3)
[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty
c:\b\build\slave\win_builder\build\src\chrome\browser\extensions\all_urls_apitest.cc(141): error: Value of: bystander
Actual: false
Expected: true
[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty
[416:2972:0818/104837:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty
[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[416:2484:0818/104837:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[ FAILED ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages, where TypeParam = and GetParam() = (1407 ms)
Original issue's description:
> [Script Injection] Allow whitelisted extensions to inject scripts everywhere
>
> Fix a regression where whitelisted extensions couldn't inject content scripts on
> other extension pages.
>
> BUG=517370
>
> Committed: https://crrev.com/9808b390b8a36c9ecb81c10dac9d18125713f57d
> Cr-Commit-Position: refs/heads/master@{#343930}
TBR=kalman@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517370
Committed: https://crrev.com/f5f4589df29346073165fe3fbefaa6fb494049c2
Cr-Commit-Position: refs/heads/master@{#343994}
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|