Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1285263005: Add use counter for prefixed intrinsic size keywords (Closed)

Created:
5 years, 4 months ago by cbiesinger
Modified:
5 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add use counter for prefixed intrinsic size keywords Once we unprefix these keywords, these use counters will let us determine which of these keywords we can remove. R=leviw@chromium.org BUG=245157 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200434

Patch Set 1 #

Total comments: 2

Patch Set 2 : use a switch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +20 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbiesinger
5 years, 4 months ago (2015-08-12 20:57:47 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1285263005/diff/1/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1285263005/diff/1/Source/core/css/parser/CSSPropertyParser.cpp#newcode374 Source/core/css/parser/CSSPropertyParser.cpp:374: if (value->id == CSSValueIntrinsic) Should we switch this ...
5 years, 4 months ago (2015-08-12 21:05:01 UTC) #2
cbiesinger
https://codereview.chromium.org/1285263005/diff/1/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1285263005/diff/1/Source/core/css/parser/CSSPropertyParser.cpp#newcode374 Source/core/css/parser/CSSPropertyParser.cpp:374: if (value->id == CSSValueIntrinsic) On 2015/08/12 21:05:01, leviw wrote: ...
5 years, 4 months ago (2015-08-12 21:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285263005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285263005/20001
5 years, 4 months ago (2015-08-12 21:14:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 22:46:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200434

Powered by Google App Engine
This is Rietveld 408576698