build/config/compiler/BUILD.gn - Issue 1285243004: Rename & rework is_chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1285243004: Rename & rework is_chromeos (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index f77139139d56671c7195df4d47eebaaf5177d8fc..54f91eff873dfc720af79adc02ad8f2004ac092a 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -78,7 +78,7 @@ config("compiler") {

}

# Linker warnings.

- if (!(is_chromeos && current_cpu == "arm") && !is_mac) {

+ if (!(is_chromeos_ui && current_cpu == "arm") && !is_mac) {

# TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580

ldflags += [ "-Wl,--fatal-warnings" ]

}