Issue 1285243004: Rename & rework is_chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1285243004: Rename & rework is_chromeos (Closed)

Created:
5 years, 4 months ago by Peter Mayo

Modified:
5 years, 4 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

More Reviews

Description

Rename & rework is_chromeos BUG=519943 TEST=Still compiles

Patch Set 2 : Tweak desktop flag #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -25 lines)			Patch
M	build/config/BUILDCONFIG.gn	View		11 chunks	+23 lines, -16 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/features.gni	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	build/config/sysroot.gni	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/config/ui.gni	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Mayo

https://codereview.chromium.org/1285243004/diff/1/build/config/sysroot.gni File build/config/sysroot.gni (left): https://codereview.chromium.org/1285243004/diff/1/build/config/sysroot.gni#oldcode22 build/config/sysroot.gni:22: } else if (is_linux && is_chrome_branded && is_official_build && ...

5 years, 4 months ago (2015-08-13 02:40:43 UTC) #1