Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 128523003: Unregister Bluetooth profile when the extension that added it is unloaded. (Closed)

Created:
6 years, 11 months ago by Tim Song
Modified:
6 years, 11 months ago
Reviewers:
keybuk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Unregister Bluetooth profile when the extension that added it is unloaded. BUG=332177 TEST=manually and new unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244000

Patch Set 1 #

Patch Set 2 : Clean up sockets for extension #

Patch Set 3 : #

Patch Set 4 : fix api test #

Patch Set 5 : fix style issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -25 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 1 2 3 4 6 chunks +29 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 1 2 3 4 10 chunks +69 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 4 chunks +46 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tim Song
6 years, 11 months ago (2014-01-08 18:48:40 UTC) #1
Tim Song
This patch associates Bluetooth profiles and sockets with the extension that uses them, and cleans ...
6 years, 11 months ago (2014-01-08 22:55:49 UTC) #2
keybuk
lgtm
6 years, 11 months ago (2014-01-08 23:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/128523003/130001
6 years, 11 months ago (2014-01-09 02:38:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=209605
6 years, 11 months ago (2014-01-09 03:22:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/128523003/370001
6 years, 11 months ago (2014-01-09 19:51:59 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 22:27:47 UTC) #7
Message was sent while issue was closed.
Change committed as 244000

Powered by Google App Engine
This is Rietveld 408576698