Send connection setup results using XHRs.

remoting/webapp/base/js/fallback_signal_strategy_unittest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * TODO(garykac): Create interfaces for LogToServer and SignalStrategy.
  * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility}
  */
 
@@ skipping 66 matching lines @@
                                         remoting.SignalStrategy.Type.XMPP),
         new remoting.MockSignalStrategy('secondary-jid',
                                         remoting.SignalStrategy.Type.WCS));
     strategy.setStateChangedCallback(onStateChange);
     strategy.setIncomingStanzaCallback(onIncomingStanzaCallback);
     primary = strategy.primary_;
     addSpies(primary);
     secondary = strategy.secondary_;
     addSpies(secondary);
     logToServer = new MockLogToServer(assert);
+    strategy.logger_ = logToServer;

[Jamie, 2015/08/14 20:48:00]

This is ugly (and wouldn't compile if we ever wanted to do that), but has the
advantage of not touching production code. I could add a setLoggerForTesting
method if you prefer.

[kelvinp, 2015/08/14 21:59:54]

I think that's ok for test.

   },
   afterEach: function() {
     onStateChange = null;
     onIncomingStanzaCallback = null;
     strategy = null;
     primary = null;
     secondary = null;
     logToServer = null;
   },
 });
@@ skipping 15 matching lines @@
     assert.ok(primary.connect.calledWith('server', 'username', 'authToken'));
 
     setState(assert, primary, remoting.SignalStrategy.State.NOT_CONNECTED,
              true);
     setState(assert, primary, remoting.SignalStrategy.State.CONNECTING, true);
     setState(assert, primary, remoting.SignalStrategy.State.HANDSHAKE, true);
 
     setState(assert, primary, remoting.SignalStrategy.State.CONNECTED, true);
     assert.equal(strategy.getJid(), 'primary-jid');
 
-    strategy.sendConnectionSetupResults(logToServer);
     logToServer.assertProgress(
         remoting.SignalStrategy.Type.XMPP,
         remoting.FallbackSignalStrategy.Progress.SUCCEEDED);
 
     assert.ok(!onIncomingStanzaCallback.called);
     primary.onIncomingStanzaCallback_('test-receive-primary');
     secondary.onIncomingStanzaCallback_('test-receive-secondary');
     assert.ok(onIncomingStanzaCallback.calledOnce);
     assert.ok(onIncomingStanzaCallback.calledWith('test-receive-primary'));
 
@@ skipping 28 matching lines @@
 
     setState(assert, secondary, remoting.SignalStrategy.State.NOT_CONNECTED,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTING,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.HANDSHAKE, true);
 
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTED, true);
     assert.equal(strategy.getJid(), 'secondary-jid');
 
-    strategy.sendConnectionSetupResults(logToServer);
     logToServer.assertProgress(
         remoting.SignalStrategy.Type.XMPP,
         remoting.FallbackSignalStrategy.Progress.FAILED,
         remoting.SignalStrategy.Type.WCS,
         remoting.FallbackSignalStrategy.Progress.SUCCEEDED);
 
     assert.ok(!onIncomingStanzaCallback.called);
     primary.onIncomingStanzaCallback_('test-receive-primary');
     secondary.onIncomingStanzaCallback_('test-receive-secondary');
     assert.ok(onIncomingStanzaCallback.calledOnce);
@@ skipping 40 matching lines @@
     this.clock.tick(strategy.PRIMARY_CONNECT_TIMEOUT_MS_ - 1);
     assert.ok(!secondary.connect.called);
     this.clock.tick(1);
     assert.ok(secondary.connect.calledWith('server', 'username', 'authToken'));
     setState(assert, secondary, remoting.SignalStrategy.State.NOT_CONNECTED,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTING,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.HANDSHAKE, true);
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTED, true);
-    strategy.sendConnectionSetupResults(logToServer);
 
     setState(assert, secondary, remoting.SignalStrategy.State.CLOSED, true);
     setState(assert, primary, remoting.SignalStrategy.State.FAILED, false);
 
     logToServer.assertProgress(
         remoting.SignalStrategy.Type.XMPP,
         remoting.FallbackSignalStrategy.Progress.TIMED_OUT,
         remoting.SignalStrategy.Type.WCS,
         remoting.FallbackSignalStrategy.Progress.SUCCEEDED,
         remoting.SignalStrategy.Type.XMPP,
@@ skipping 34 matching lines @@
                                true);
     setState(assert, primary, remoting.SignalStrategy.State.CONNECTING, true);
     this.clock.tick(strategy.PRIMARY_CONNECT_TIMEOUT_MS_);
     assert.ok(secondary.connect.calledWith('server', 'username', 'authToken'));
     setState(assert, secondary, remoting.SignalStrategy.State.NOT_CONNECTED,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTING,
              false);
     setState(assert, secondary, remoting.SignalStrategy.State.HANDSHAKE, true);
     setState(assert, secondary, remoting.SignalStrategy.State.CONNECTED, true);
-    strategy.sendConnectionSetupResults(logToServer);
 
     setState(assert, primary, remoting.SignalStrategy.State.HANDSHAKE, false);
     setState(assert, primary, remoting.SignalStrategy.State.CONNECTED, false);
 
     logToServer.assertProgress(
         remoting.SignalStrategy.Type.XMPP,
         remoting.FallbackSignalStrategy.Progress.TIMED_OUT,
         remoting.SignalStrategy.Type.WCS,
         remoting.FallbackSignalStrategy.Progress.SUCCEEDED,
         remoting.SignalStrategy.Type.XMPP,
         remoting.FallbackSignalStrategy.Progress.SUCCEEDED_LATE);
   }
 );
 
 })();