Send connection setup results using XHRs.

remoting/webapp/base/js/fallback_signal_strategy.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 56 matching lines @@
   /** @private {string} */
   this.username_ = '';
 
   /** @private {string} */
   this.authToken_ = '';
 
   /** @private {number} */
   this.primaryConnectTimerId_ = 0;
 
   /** @private {remoting.Logger} */
-  this.logger_ = null;
+  this.logger_ = new remoting.SessionLogger(
+      remoting.ChromotingEvent.Role.CLIENT,
+      remoting.TelemetryEventWriter.Client.write
+  );
 
   /**
    * @type {Array<{strategyType: remoting.SignalStrategy.Type,
                     progress: remoting.FallbackSignalStrategy.Progress}>}
    */
   this.connectionSetupResults_ = [];
 
 };
 
 /**
@@ skipping 60 matching lines @@
 };
 
 /**
  * Sends a message. Can be called only in CONNECTED state.
  * @param {string} message
  */
 remoting.FallbackSignalStrategy.prototype.sendMessage = function(message) {
   this.getConnectedSignalStrategy_().sendMessage(message);
 };
 
-/**
- * Send any messages accumulated during connection set-up.
- *
- * @param {remoting.Logger} logToServer The Logger instance for the
- *     connection.
- */
-remoting.FallbackSignalStrategy.prototype.sendConnectionSetupResults =
-    function(logToServer) {
-  this.logger_ = logToServer;
-  this.sendConnectionSetupResultsInternal_();
-}
-
-remoting.FallbackSignalStrategy.prototype.sendConnectionSetupResultsInternal_ =
-    function() {
-  for (var i = 0; i < this.connectionSetupResults_.length; ++i) {
-    var result = this.connectionSetupResults_[i];
-    this.logger_.logSignalStrategyProgress(result.strategyType,
-                                                result.progress);
-  }
-  this.connectionSetupResults_ = [];
-};
-
 /** @return {remoting.SignalStrategy.State} Current state */
 remoting.FallbackSignalStrategy.prototype.getState = function() {
   return (this.externalState_ === null)
       ? remoting.SignalStrategy.State.NOT_CONNECTED
       : this.externalState_;
 };
 
 /** @return {!remoting.Error} Error when in FAILED state. */
 remoting.FallbackSignalStrategy.prototype.getError = function() {
   console.assert(this.state_ == this.State.SECONDARY_FAILED,
@@ skipping 160 matching lines @@
 
 /**
  * @param {remoting.SignalStrategy} strategy
  * @param {remoting.FallbackSignalStrategy.Progress} progress
  * @private
  */
 remoting.FallbackSignalStrategy.prototype.updateProgress_ = function(
     strategy, progress) {
   console.log('FallbackSignalStrategy progress: ' + strategy.getType() + ' ' +
       progress);
-  this.connectionSetupResults_.push({
-    'strategyType': strategy.getType(),
-    'progress': progress
-  });
-  if (this.logger_) {
-    this.sendConnectionSetupResultsInternal_();
-  }
+  this.logger_.logSignalStrategyProgress(strategy.getType(), progress);

[Jamie, 2015/08/14 20:48:00]

Right now, this causes errors in the background page because the service is not
running. LMK if there's a clean way to disable it, or we can just accept the
errors in the short term.

[kelvinp, 2015/08/14 21:59:54]

I think it is ok to ignore them in the short term

 };