Send connection setup results using XHRs.

Send connection setup results using XHRs.

This allows them to be sent immediately, rather than only when the session
starts, which will give us insight into cases where both signal strategies
fail. It also simplifies the code a little.

Committed: https://crrev.com/5e173e3e5d0dde16a252d0ae141742aab698f7de
Cr-Commit-Position: refs/heads/master@{#343516}

[Jamie, 2015-08-14 20:47:59]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-08-14 20:48:00]

ptal

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
File remoting/webapp/base/js/fallback_signal_strategy.js (right):

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
remoting/webapp/base/js/fallback_signal_strategy.js:341:
this.logger_.logSignalStrategyProgress(strategy.getType(), progress);
Right now, this causes errors in the background page because the service is not
running. LMK if there's a clean way to disable it, or we can just accept the
errors in the short term.

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
File remoting/webapp/base/js/fallback_signal_strategy_unittest.js (right):

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
remoting/webapp/base/js/fallback_signal_strategy_unittest.js:87:
strategy.logger_ = logToServer;
This is ugly (and wouldn't compile if we ever wanted to do that), but has the
advantage of not touching production code. I could add a setLoggerForTesting
method if you prefer.

[kelvinp, 2015-08-14 21:59:54]

lgtm

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
File remoting/webapp/base/js/fallback_signal_strategy.js (right):

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
remoting/webapp/base/js/fallback_signal_strategy.js:341:
this.logger_.logSignalStrategyProgress(strategy.getType(), progress);
On 2015/08/14 20:48:00, Jamie wrote:
> Right now, this causes errors in the background page because the service is
not
> running. LMK if there's a clean way to disable it, or we can just accept the
> errors in the short term.

I think it is ok to ignore them in the short term

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
File remoting/webapp/base/js/fallback_signal_strategy_unittest.js (right):

https://codereview.chromium.org/1285213006/diff/1/remoting/webapp/base/js/fal...
remoting/webapp/base/js/fallback_signal_strategy_unittest.js:87:
strategy.logger_ = logToServer;
On 2015/08/14 20:48:00, Jamie wrote:
> This is ugly (and wouldn't compile if we ever wanted to do that), but has the
> advantage of not touching production code. I could add a setLoggerForTesting
> method if you prefer.

I think that's ok for test.

[Jamie, 2015-08-14 22:09:45]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2015-08-14 22:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285213006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285213006/1

[commit-bot: I haz the power, 2015-08-14 22:48:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-14 22:48:52]

Patchset 1 (id:??) landed as
https://crrev.com/5e173e3e5d0dde16a252d0ae141742aab698f7de
Cr-Commit-Position: refs/heads/master@{#343516}