Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1285173002: dart2js cps: Rewrite more List operations into JS array operations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: receiverIsNotNull -> optional param Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index 23deb5fce06f2046205ab9c0e46c739752bb68dd..d82377a63ba7c085ed9625a37717f2606d235b97 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -496,7 +496,6 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
return 'CreateInstance $className($arguments)';
}
-
@override
String visitReadTypeVariable(ReadTypeVariable node) {
return 'Read ${node.variable.element} ${visitExpression(node.target)}';
@@ -536,6 +535,13 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
}
@override
+ String visitApplyBuiltinMethod(ApplyBuiltinMethod node) {
+ String receiver = visitExpression(node.receiver);
+ String args = node.arguments.map(visitExpression).join(', ');
+ return 'ApplyBuiltinMethod ${node.method} $receiver ($args)';
+ }
+
+ @override
String visitGetLength(GetLength node) {
String object = visitExpression(node.object);
return 'GetLength($object)';

Powered by Google App Engine
This is Rietveld 408576698